From: Daniel Kiper <daniel.kiper@oracle.com>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: andrew.cooper3@citrix.com, dyoung@redhat.com, horms@verge.net.au,
kexec@lists.infradead.org, konrad.wilk@oracle.com
Subject: Re: [PATCH v2 01/12] crashdump/x86: Add print_crashkernel_region_size() function
Date: Tue, 7 Feb 2017 15:55:38 +0100 [thread overview]
Message-ID: <20170207145538.GC13477@olila.local.net-space.pl> (raw)
In-Reply-To: <1486410144-28595-2-git-send-email-eric.devolder@oracle.com>
On Mon, Feb 06, 2017 at 01:42:13PM -0600, Eric DeVolder wrote:
> From: Daniel Kiper <daniel.kiper@oracle.com>
>
> Crash kernel region size is available via sysfs on Linux running on
> bare metal. However, this does not work when Linux runs as Xen dom0.
> In this case Xen crash kernel region size should be established using
> __HYPERVISOR_kexec_op hypercall (Linux kernel kexec functionality does
> not make a lot of sense in Xen dom0). Sadly hypercalls are not easily
> accessible using shell scripts or something like that. Potentially we
> can check "xl dmesg" output for crashkernel option but this is not nice.
> So, let's add this functionality, for Linux running on bare metal and
> as Xen dom0, to kexec-tools. This way kdump scripts may establish crash
> kernel region size in one way regardless of platform. All burden of
> platform detection lies on kexec-tools.
>
> Figure (and unit) displayed by this new kexec-tools functionality is
> the same as one taken from /sys/kernel/kexec_crash_size.
>
> This patch just adds print_crashkernel_region_size() function, which
> prints crash kernel region size, for x86 arch. Next patches will add
> same named function for other archs supported by kexec-tools. Last patch
> of this series will export this functionality to the userspace via
> separate kexec utility option.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
> ---
> v0: Interal version.
> v1: Posted to kexec-tools mailing list
> v2: Incorporated feedback:
> - utilize the is_crashkernel_mem_reserved() function common in all archs
> - for ppc and ppc64, utilize device-tree values to print size
> - for unsupported architectures, print appropriate message
Please do not blindly copy description of changes from patch #00. I think it
makes more sense if you tell us what really has been changed in this patch.
Otherwise LGTM.
Daniel
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-02-07 14:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 19:42 [PATCH v2 00/12] crashdump: Add print_crashkernel_region_size() function Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 01/12] crashdump/x86: " Eric DeVolder
2017-02-07 14:55 ` Daniel Kiper [this message]
2017-02-06 19:42 ` [PATCH v2 02/12] crashdump/arm: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 03/12] crashdump/cris: " Eric DeVolder
2017-02-07 15:07 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 04/12] crashdump/ia64: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 05/12] crashdump/m68k: " Eric DeVolder
2017-02-07 15:09 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 06/12] crashdump/mips: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 07/12] crashdump/ppc: " Eric DeVolder
2017-02-07 16:06 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 08/12] crashdump/ppc64: " Eric DeVolder
2017-02-06 19:50 ` Konrad Rzeszutek Wilk
2017-02-07 16:09 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 09/12] crashdump/s390: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 10/12] crashdump/sh: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 11/12] kexec: Add option to get crash kernel region size Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 12/12] " Eric DeVolder
2017-02-07 16:14 ` Daniel Kiper
2017-02-07 14:42 ` [PATCH v2 00/12] crashdump: Add print_crashkernel_region_size() function Daniel Kiper
2017-02-08 8:37 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207145538.GC13477@olila.local.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=dyoung@redhat.com \
--cc=eric.devolder@oracle.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox