From: Simon Horman <horms@verge.net.au>
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org, Yinghai Lu <yinghai@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memmap: Parse "Reserved" together with "reserved"
Date: Wed, 26 Apr 2017 12:49:24 +0200 [thread overview]
Message-ID: <20170426104924.GA23556@verge.net.au> (raw)
In-Reply-To: <20170426073148.GA7367@dhcp-128-65.nay.redhat.com>
On Wed, Apr 26, 2017 at 03:31:48PM +0800, Dave Young wrote:
> On 04/26/17 at 03:28pm, Dave Young wrote:
> > On 04/26/17 at 08:22am, Ingo Molnar wrote:
> > >
> > > * Yinghai Lu <yinghai@kernel.org> wrote:
> > >
> > > > For x86 with recent kernel after
> > > > commit 640e1b38b0 ("x86/boot/e820: Basic cleanup of e820.c")
> > > > change "reserved" to "Reserved" in /sys firmware memmap and /proc/iomem.
> > > >
> > > > So here, we add handling for that too.
> > > >
> > > > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > > >
> > > > ---
> > > > kexec/arch/i386/crashdump-x86.c | 2 ++
> > > > kexec/arch/ia64/kexec-ia64.c | 2 ++
> > > > kexec/arch/mips/kexec-mips.c | 2 ++
> > > > kexec/firmware_memmap.c | 2 ++
> > > > 4 files changed, 8 insertions(+)
> > >
> > > I'd rather fix the bug I introduced and undo the reserved->Reserved string change
> >
> > This patch parses both 'reserved' and 'Reserved' it should be fine, but
> > reverting the change in kernel sounds better..
>
> Hmm, after press sending I noticed old kexec-tools with new kernel, it
> is still a problem, so we'd better to revert the kernel changes.
FWIW, if the kernel change hasn't hit a release then reverting (the
reserved->Reserved portion of) it would be my preference.
> > > in e820.c: I didn't realize that it's exposed in sysfs and had quasi-ABI
> > > consequences for kexec.
> > >
> > > Agreed?
> > >
> > > Thanks,
> > >
> > > Ingo
> > >
> > > _______________________________________________
> > > kexec mailing list
> > > kexec@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/kexec
> >
> > Thanks
> > Dave
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2017-04-26 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 0:55 [PATCH] memmap: Parse "Reserved" together with "reserved" Yinghai Lu
2017-04-26 6:01 ` Dave Young
2017-04-26 6:22 ` Ingo Molnar
2017-04-26 7:28 ` Dave Young
2017-04-26 7:31 ` Dave Young
2017-04-26 10:49 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426104924.GA23556@verge.net.au \
--to=horms@verge.net.au \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox