Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lianbo Jiang <lijiang@redhat.com>
To: kexec@lists.infradead.org
Cc: kasong@redhat.com, bhe@redhat.com, piliu@redhat.com,
	bhsharma@redhat.com, junw99@yahoo.com, horms@verge.net.au,
	dyoung@redhat.com
Subject: [PATCH 0/4 v2] Limit the size of vmcore-dmesg.txt to 2G
Date: Fri, 23 Aug 2019 20:05:35 +0800	[thread overview]
Message-ID: <20190823120539.18330-1-lijiang@redhat.com> (raw)

[PATCH 1/4] Cleanup: remove the read_elf_kcore()
Here, no need to wrap the read_elf() again, lets invoke it directly.
So remove the read_elf_kcore() and clean up redundant code.

[PATCH 2/4] Fix an error definition about the variable 'fname'
The variable 'fname' is mistakenly defined two twice, the first definition
is in the vmcore-dmesg.c, and the second definition is in the elf_info.c.
That is confused and incorrect although it's a static type, because the
value of variable 'fname' is not assigned(set) in elf_info.c. Anyway, its
value will be always 'null' when printing an error information.

[PATCH 3/4] Cleanup: move it back from util_lib/elf_info.c
Some code related to vmcore-dmesg.c is put into the util_lib, which
is not very reasonable, so lets move it back and tidy up those code.
In addition, that will also help to limit the size of vmcore-dmesg.txt.

[PATCH 4/4] Limit the size of vmcore-dmesg.txt to 2G
With some corrupted vmcore files, the vmcore-dmesg.txt file may
grow forever till the kdump disk becomes full. Lets limit the
size of vmcore-dmesg.txt to avoid such problems.

BTW: I tested this patch series on x86 64 and arm64, it also worked well.

Changes since v1:
[1] split them([patch 1/4] and [patch 2/4]) into a separate patch.
[2] remove a typedef definition for handler.
[3] remove some changes of variable 'fname' and fix its error.

Lianbo Jiang (4):
  Cleanup: remove the read_elf_kcore()
  Fix an error definition about the variable 'fname'
  Cleanup: move it back from util_lib/elf_info.c
  Limit the size of vmcore-dmesg.txt to 2G

 kexec/arch/arm64/kexec-arm64.c |  2 +-
 util_lib/elf_info.c            | 65 ++++++++--------------------------
 util_lib/include/elf_info.h    |  4 +--
 vmcore-dmesg/vmcore-dmesg.c    | 42 ++++++++++++++++++++--
 4 files changed, 57 insertions(+), 56 deletions(-)

-- 
2.17.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2019-08-23 12:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 12:05 Lianbo Jiang [this message]
2019-08-23 12:05 ` [PATCH 1/4 v2] Cleanup: remove the read_elf_kcore() Lianbo Jiang
2019-08-23 12:05 ` [PATCH 2/4 v2] Fix an error definition about the variable 'fname' Lianbo Jiang
2019-08-23 12:05 ` [PATCH 3/4 v2] Cleanup: move it back from util_lib/elf_info.c Lianbo Jiang
2019-08-23 12:05 ` [PATCH 4/4 v2] Limit the size of vmcore-dmesg.txt to 2G Lianbo Jiang
2019-08-28  9:18 ` [PATCH 0/4 " lijiang
2019-09-03 14:37   ` Simon Horman
2019-09-04 13:29     ` lijiang
2019-09-08 12:40       ` Simon Horman
2019-09-09  1:03         ` lijiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823120539.18330-1-lijiang@redhat.com \
    --to=lijiang@redhat.com \
    --cc=bhe@redhat.com \
    --cc=bhsharma@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=horms@verge.net.au \
    --cc=junw99@yahoo.com \
    --cc=kasong@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=piliu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox