From: Lianbo Jiang <lijiang@redhat.com>
To: kexec@lists.infradead.org
Cc: kasong@redhat.com, bhe@redhat.com, piliu@redhat.com,
bhsharma@redhat.com, junw99@yahoo.com, horms@verge.net.au,
dyoung@redhat.com
Subject: [PATCH 2/4 v2] Fix an error definition about the variable 'fname'
Date: Fri, 23 Aug 2019 20:05:37 +0800 [thread overview]
Message-ID: <20190823120539.18330-3-lijiang@redhat.com> (raw)
In-Reply-To: <20190823120539.18330-1-lijiang@redhat.com>
The variable 'fname' is mistakenly defined two twice, the first definition
is in the vmcore-dmesg.c, and the second definition is in the elf_info.c.
That is confused and incorrect although it's a static type, because the
value of variable 'fname' is not assigned(set) in elf_info.c. Anyway, its
value will be always 'null' when printing an error information.
Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
---
util_lib/elf_info.c | 2 +-
vmcore-dmesg/vmcore-dmesg.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/util_lib/elf_info.c b/util_lib/elf_info.c
index d9397ecd8626..5d0efaafab53 100644
--- a/util_lib/elf_info.c
+++ b/util_lib/elf_info.c
@@ -20,7 +20,7 @@
/* The 32bit and 64bit note headers make it clear we don't care */
typedef Elf32_Nhdr Elf_Nhdr;
-static const char *fname;
+const char *fname;
static Elf64_Ehdr ehdr;
static Elf64_Phdr *phdr;
static int num_pt_loads;
diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
index 7a386b380291..bebc348a657e 100644
--- a/vmcore-dmesg/vmcore-dmesg.c
+++ b/vmcore-dmesg/vmcore-dmesg.c
@@ -3,7 +3,7 @@
/* The 32bit and 64bit note headers make it clear we don't care */
typedef Elf32_Nhdr Elf_Nhdr;
-static const char *fname;
+extern const char *fname;
int main(int argc, char **argv)
{
--
2.17.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-08-23 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 12:05 [PATCH 0/4 v2] Limit the size of vmcore-dmesg.txt to 2G Lianbo Jiang
2019-08-23 12:05 ` [PATCH 1/4 v2] Cleanup: remove the read_elf_kcore() Lianbo Jiang
2019-08-23 12:05 ` Lianbo Jiang [this message]
2019-08-23 12:05 ` [PATCH 3/4 v2] Cleanup: move it back from util_lib/elf_info.c Lianbo Jiang
2019-08-23 12:05 ` [PATCH 4/4 v2] Limit the size of vmcore-dmesg.txt to 2G Lianbo Jiang
2019-08-28 9:18 ` [PATCH 0/4 " lijiang
2019-09-03 14:37 ` Simon Horman
2019-09-04 13:29 ` lijiang
2019-09-08 12:40 ` Simon Horman
2019-09-09 1:03 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823120539.18330-3-lijiang@redhat.com \
--to=lijiang@redhat.com \
--cc=bhe@redhat.com \
--cc=bhsharma@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=junw99@yahoo.com \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=piliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox