From: Sven Schnelle <svens@linux.ibm.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org, Sven Schnelle <svens@linux.ibm.com>,
Alexander Egorenkov <egorenar@linux.ibm.com>
Subject: [PATCH 2/3] s390: use KEXEC_ALL_OPTIONS
Date: Mon, 22 Nov 2021 08:14:00 +0100 [thread overview]
Message-ID: <20211122071401.3106858-3-svens@linux.ibm.com> (raw)
In-Reply-To: <20211122071401.3106858-1-svens@linux.ibm.com>
KEXEC_ALL_OPTIONS could be used instead defining the same
array several times. This makes code easier to maintain when
new options are added.
Suggested-by: Alexander Egorenkov <egorenar@linux.ibm.com>
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Reviewed-by: Alexander Egorenkov <egorenar@linux.ibm.com>
---
kexec/arch/s390/kexec-image.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/kexec/arch/s390/kexec-image.c b/kexec/arch/s390/kexec-image.c
index 7747d02399db..dbeb689b830a 100644
--- a/kexec/arch/s390/kexec-image.c
+++ b/kexec/arch/s390/kexec-image.c
@@ -58,10 +58,7 @@ int image_s390_load_file(int argc, char **argv, struct kexec_info *info)
static const struct option options[] =
{
- KEXEC_OPTIONS
- {"command-line", 1, 0, OPT_APPEND},
- {"append", 1, 0, OPT_APPEND},
- {"initrd", 1, 0, OPT_RAMDISK},
+ KEXEC_ALL_OPTIONS
{0, 0, 0, 0},
};
static const char short_options[] = KEXEC_OPT_STR "";
@@ -111,10 +108,7 @@ image_s390_load(int argc, char **argv, const char *kernel_buf,
static const struct option options[] =
{
- KEXEC_OPTIONS
- {"command-line", 1, 0, OPT_APPEND},
- {"append", 1, 0, OPT_APPEND},
- {"initrd", 1, 0, OPT_RAMDISK},
+ KEXEC_ALL_OPTIONS
{0, 0, 0, 0},
};
static const char short_options[] = KEXEC_OPT_STR "";
--
2.25.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-11-22 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 7:13 [PATCH 0/3] s390: add support for extended cmdline length Sven Schnelle
2021-11-22 7:13 ` [PATCH 1/3] s390: add variable command line size Sven Schnelle
2021-12-07 14:29 ` Philipp Rudo
2021-12-07 16:06 ` Sven Schnelle
2021-11-22 7:14 ` Sven Schnelle [this message]
2021-11-22 7:14 ` [PATCH 3/3] s390: add support for --reuse-cmdline Sven Schnelle
2021-12-07 14:34 ` Philipp Rudo
2021-12-07 16:12 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122071401.3106858-3-svens@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=egorenar@linux.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox