Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v4 0/4] Convert vmcore to use an iov_iter
Date: Fri, 18 Mar 2022 17:37:02 +0800	[thread overview]
Message-ID: <20220318093706.161534-1-bhe@redhat.com> (raw)

Copy the description of v3 cover letter from Willy:
===
For some reason several people have been sending bad patches to fix
compiler warnings in vmcore recently.  Here's how it should be done.
Compile-tested only on x86.  As noted in the first patch, s390 should
take this conversion a bit further, but I'm not inclined to do that
work myself.

This series resends Willy's v3 patches which includes patch 1~3, and
append one patch to clean up the open code pointed out by Al.

Al's concerns to v3 patches and my reply after investigation:
https://lore.kernel.org/all/YhiTN0MORoQmFFkO at MiWiFi-R3L-srv/T/#u

Willy's v3 patchset:
[PATCH v3 0/3] Convert vmcore to use an iov_iter
https://lore.kernel.org/all/20211213143927.3069508-1-willy at infradead.org/T/#u

Changelog:
===
v4:
 - Append one patch to replace the open code with iov_iter_count().
   This is suggested by Al.
 - Fix a indentation error by replacing space with tab in
   arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The
   rest of patch 1~3 are untouched.
 - Add Christopy's Reviewed-by and my Acked-by for patch 1~3.
v3:
 - Send the correct patches this time
v2:
 - Removed unnecessary kernel-doc
 - Included uio.h to fix compilation problems
 - Made read_from_oldmem_iter static to avoid compile warnings during the
   conversion
 - Use iov_iter_truncate() (Christoph)



Baoquan He (1):
  fs/proc/vmcore: Use iov_iter_count()

Matthew Wilcox (Oracle) (3):
  vmcore: Convert copy_oldmem_page() to take an iov_iter
  vmcore: Convert __read_vmcore to use an iov_iter
  vmcore: Convert read_from_oldmem() to take an iov_iter

 arch/arm/kernel/crash_dump.c     |  27 +------
 arch/arm64/kernel/crash_dump.c   |  29 +------
 arch/ia64/kernel/crash_dump.c    |  32 +-------
 arch/mips/kernel/crash_dump.c    |  27 +------
 arch/powerpc/kernel/crash_dump.c |  35 ++-------
 arch/riscv/kernel/crash_dump.c   |  26 +------
 arch/s390/kernel/crash_dump.c    |  13 ++--
 arch/sh/kernel/crash_dump.c      |  29 ++-----
 arch/x86/kernel/crash_dump_32.c  |  29 +------
 arch/x86/kernel/crash_dump_64.c  |  48 ++++--------
 fs/proc/vmcore.c                 | 130 +++++++++++++------------------
 include/linux/crash_dump.h       |  19 ++---
 12 files changed, 123 insertions(+), 321 deletions(-)

-- 
2.34.1



             reply	other threads:[~2022-03-18  9:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18  9:37 Baoquan He [this message]
2022-03-18  9:37 ` [PATCH v4 1/4] vmcore: Convert copy_oldmem_page() to take an iov_iter Baoquan He
2022-03-18  9:37 ` [PATCH v4 2/4] vmcore: Convert __read_vmcore to use " Baoquan He
2022-03-18  9:37 ` [PATCH v4 3/4] vmcore: Convert read_from_oldmem() to take " Baoquan He
2022-03-18  9:37 ` [PATCH v4 4/4] fs/proc/vmcore: Use iov_iter_count() Baoquan He
2022-03-18 13:48   ` David Laight
2022-03-18 13:50     ` Matthew Wilcox
2022-03-21  3:54     ` 'Baoquan He'
2022-03-18 10:25 ` [PATCH v4 0/4] Convert vmcore to use an iov_iter Baoquan He
2022-03-31 11:25 ` Baoquan He
2022-03-31 14:36   ` Matthew Wilcox
2022-04-01  0:14     ` Andrew Morton
2022-04-01  1:23       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318093706.161534-1-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox