From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v4 4/4] fs/proc/vmcore: Use iov_iter_count()
Date: Fri, 18 Mar 2022 17:37:06 +0800 [thread overview]
Message-ID: <20220318093706.161534-5-bhe@redhat.com> (raw)
In-Reply-To: <20220318093706.161534-1-bhe@redhat.com>
To replace open coded iter->count. This makes code cleaner.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
fs/proc/vmcore.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 4cbb8db7c507..ed58a7edc821 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -319,21 +319,21 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
u64 start;
struct vmcore *m = NULL;
- if (iter->count == 0 || *fpos >= vmcore_size)
+ if (!iov_iter_count(iter) || *fpos >= vmcore_size)
return 0;
iov_iter_truncate(iter, vmcore_size - *fpos);
/* Read ELF core header */
if (*fpos < elfcorebuf_sz) {
- tsz = min(elfcorebuf_sz - (size_t)*fpos, iter->count);
+ tsz = min(elfcorebuf_sz - (size_t)*fpos, iov_iter_count(iter));
if (copy_to_iter(elfcorebuf + *fpos, tsz, iter) < tsz)
return -EFAULT;
*fpos += tsz;
acc += tsz;
/* leave now if filled buffer already */
- if (iter->count == 0)
+ if (!iov_iter_count(iter))
return acc;
}
@@ -354,7 +354,7 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
/* Read device dumps */
if (*fpos < elfcorebuf_sz + vmcoredd_orig_sz) {
tsz = min(elfcorebuf_sz + vmcoredd_orig_sz -
- (size_t)*fpos, iter->count);
+ (size_t)*fpos, iov_iter_count(iter));
start = *fpos - elfcorebuf_sz;
if (vmcoredd_copy_dumps(iter, start, tsz))
return -EFAULT;
@@ -363,13 +363,14 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
acc += tsz;
/* leave now if filled buffer already */
- if (!iter->count)
+ if (!iov_iter_count(iter))
return acc;
}
#endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
/* Read remaining elf notes */
- tsz = min(elfcorebuf_sz + elfnotes_sz - (size_t)*fpos, iter->count);
+ tsz = min(elfcorebuf_sz + elfnotes_sz - (size_t)*fpos,
+ iov_iter_count(iter));
kaddr = elfnotes_buf + *fpos - elfcorebuf_sz - vmcoredd_orig_sz;
if (copy_to_iter(kaddr, tsz, iter) < tsz)
return -EFAULT;
@@ -378,7 +379,7 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
acc += tsz;
/* leave now if filled buffer already */
- if (iter->count == 0)
+ if (!iov_iter_count(iter))
return acc;
}
@@ -386,7 +387,7 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
if (*fpos < m->offset + m->size) {
tsz = (size_t)min_t(unsigned long long,
m->offset + m->size - *fpos,
- iter->count);
+ iov_iter_count(iter));
start = m->paddr + *fpos - m->offset;
tmp = read_from_oldmem(iter, tsz, &start,
cc_platform_has(CC_ATTR_MEM_ENCRYPT));
@@ -396,7 +397,7 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos)
acc += tsz;
/* leave now if filled buffer already */
- if (iter->count == 0)
+ if (!iov_iter_count(iter))
return acc;
}
}
--
2.34.1
next prev parent reply other threads:[~2022-03-18 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 9:37 [PATCH v4 0/4] Convert vmcore to use an iov_iter Baoquan He
2022-03-18 9:37 ` [PATCH v4 1/4] vmcore: Convert copy_oldmem_page() to take " Baoquan He
2022-03-18 9:37 ` [PATCH v4 2/4] vmcore: Convert __read_vmcore to use " Baoquan He
2022-03-18 9:37 ` [PATCH v4 3/4] vmcore: Convert read_from_oldmem() to take " Baoquan He
2022-03-18 9:37 ` Baoquan He [this message]
2022-03-18 13:48 ` [PATCH v4 4/4] fs/proc/vmcore: Use iov_iter_count() David Laight
2022-03-18 13:50 ` Matthew Wilcox
2022-03-21 3:54 ` 'Baoquan He'
2022-03-18 10:25 ` [PATCH v4 0/4] Convert vmcore to use an iov_iter Baoquan He
2022-03-31 11:25 ` Baoquan He
2022-03-31 14:36 ` Matthew Wilcox
2022-04-01 0:14 ` Andrew Morton
2022-04-01 1:23 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318093706.161534-5-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox