* [PATCH] kexec_file: add kexec_file flag to support debug printing
@ 2023-11-14 15:20 Baoquan He
2023-11-27 13:32 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Baoquan He @ 2023-11-14 15:20 UTC (permalink / raw)
To: kexec; +Cc: horms, Baoquan He
This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed
to kernel when '-d' is added with kexec_file_load interface. With that
flag enabled, kernel can enable the debugging message printing.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
kexec/kexec-syscall.h | 1 +
kexec/kexec.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h
index 2559bffb93da..73e52543e1b0 100644
--- a/kexec/kexec-syscall.h
+++ b/kexec/kexec-syscall.h
@@ -119,6 +119,7 @@ static inline long kexec_file_load(int kernel_fd, int initrd_fd,
#define KEXEC_FILE_UNLOAD 0x00000001
#define KEXEC_FILE_ON_CRASH 0x00000002
#define KEXEC_FILE_NO_INITRAMFS 0x00000004
+#define KEXEC_FILE_DEBUG 0x00000008
/* These values match the ELF architecture values.
* Unless there is a good reason that should continue to be the case.
diff --git a/kexec/kexec.c b/kexec/kexec.c
index 08edfca2349a..b5393e3b20aa 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1477,6 +1477,7 @@ int main(int argc, char *argv[])
return 0;
case OPT_DEBUG:
kexec_debug = 1;
+ kexec_file_flags |= KEXEC_FILE_DEBUG;
break;
case OPT_NOIFDOWN:
skip_ifdown = 1;
--
2.41.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
2023-11-14 15:20 [PATCH] kexec_file: add kexec_file flag to support debug printing Baoquan He
@ 2023-11-27 13:32 ` Simon Horman
2023-11-27 23:22 ` Baoquan He
2024-03-15 8:11 ` Baoquan He
0 siblings, 2 replies; 6+ messages in thread
From: Simon Horman @ 2023-11-27 13:32 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec
On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote:
> This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed
> to kernel when '-d' is added with kexec_file_load interface. With that
> flag enabled, kernel can enable the debugging message printing.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
Thanks,
this looks fine to me.
But perhaps the corresponding Kernel patch should land first?
Let me know what you think.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
2023-11-27 13:32 ` Simon Horman
@ 2023-11-27 23:22 ` Baoquan He
2024-03-15 8:11 ` Baoquan He
1 sibling, 0 replies; 6+ messages in thread
From: Baoquan He @ 2023-11-27 23:22 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec
On 11/27/23 at 01:32pm, Simon Horman wrote:
> On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote:
> > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed
> > to kernel when '-d' is added with kexec_file_load interface. With that
> > flag enabled, kernel can enable the debugging message printing.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
> Thanks,
>
> this looks fine to me.
> But perhaps the corresponding Kernel patch should land first?
> Let me know what you think.
Yes, agree. I will ping you once kernel patches are taken. Thanks.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
2023-11-27 13:32 ` Simon Horman
2023-11-27 23:22 ` Baoquan He
@ 2024-03-15 8:11 ` Baoquan He
2024-03-15 8:39 ` Simon Horman
1 sibling, 1 reply; 6+ messages in thread
From: Baoquan He @ 2024-03-15 8:11 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec
On 11/27/23 at 01:32pm, Simon Horman wrote:
> On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote:
> > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed
> > to kernel when '-d' is added with kexec_file_load interface. With that
> > flag enabled, kernel can enable the debugging message printing.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
> Thanks,
>
> this looks fine to me.
> But perhaps the corresponding Kernel patch should land first?
> Let me know what you think.
Ping, the relevant kernel patches landed in mainline kernel, please help
merge this patch.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
2024-03-15 8:11 ` Baoquan He
@ 2024-03-15 8:39 ` Simon Horman
2024-03-15 8:45 ` Baoquan He
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2024-03-15 8:39 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec
On Fri, Mar 15, 2024 at 04:11:50PM +0800, Baoquan He wrote:
> On 11/27/23 at 01:32pm, Simon Horman wrote:
> > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote:
> > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed
> > > to kernel when '-d' is added with kexec_file_load interface. With that
> > > flag enabled, kernel can enable the debugging message printing.
> > >
> > > Signed-off-by: Baoquan He <bhe@redhat.com>
> >
> > Thanks,
> >
> > this looks fine to me.
> > But perhaps the corresponding Kernel patch should land first?
> > Let me know what you think.
>
> Ping, the relevant kernel patches landed in mainline kernel, please help
> merge this patch.
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec_file: add kexec_file flag to support debug printing
2024-03-15 8:39 ` Simon Horman
@ 2024-03-15 8:45 ` Baoquan He
0 siblings, 0 replies; 6+ messages in thread
From: Baoquan He @ 2024-03-15 8:45 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec
On 03/15/24 at 09:39am, Simon Horman wrote:
> On Fri, Mar 15, 2024 at 04:11:50PM +0800, Baoquan He wrote:
> > On 11/27/23 at 01:32pm, Simon Horman wrote:
> > > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote:
> > > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed
> > > > to kernel when '-d' is added with kexec_file_load interface. With that
> > > > flag enabled, kernel can enable the debugging message printing.
> > > >
> > > > Signed-off-by: Baoquan He <bhe@redhat.com>
> > >
> > > Thanks,
> > >
> > > this looks fine to me.
> > > But perhaps the corresponding Kernel patch should land first?
> > > Let me know what you think.
> >
> > Ping, the relevant kernel patches landed in mainline kernel, please help
> > merge this patch.
>
> Thanks, applied.
Great, thanks a lot.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-15 8:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-14 15:20 [PATCH] kexec_file: add kexec_file flag to support debug printing Baoquan He
2023-11-27 13:32 ` Simon Horman
2023-11-27 23:22 ` Baoquan He
2024-03-15 8:11 ` Baoquan He
2024-03-15 8:39 ` Simon Horman
2024-03-15 8:45 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox