* [PATCH] LoongArch: Load vmlinux.efi to the link address
@ 2023-11-24 15:46 WANG Rui
2023-11-27 13:46 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: WANG Rui @ 2023-11-24 15:46 UTC (permalink / raw)
To: kexec; +Cc: Huacai Chen, WANG Rui
Currently, kexec loads vmlinux.efi to address 0 instead of the link
address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
pei_loongarch_load: kernel_segment: 0000000000000000
pei_loongarch_load: kernel_entry: 00000000015dc000
pei_loongarch_load: image_size: 0000000001f30000
pei_loongarch_load: text_offset: 0000000000200000
pei_loongarch_load: phys_offset: 0000000000000000
pei_loongarch_load: PE format: yes
loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
kexec_load: entry = 0x15dc000 flags = 0x1020000
nr_segments = 2
segment[0].buf = 0x7fffef664010
segment[0].bufsz = 0x1de9a00
segment[0].mem = (nil)
segment[0].memsz = 0x1f30000
segment[1].buf = 0x555555e480b0
segment[1].bufsz = 0x200
segment[1].mem = 0x1f30000
segment[1].memsz = 0x4000
This patch adds `text_offset` when adding kernel segment to load
vmlinux.efi to the link address.
pei_loongarch_load: kernel_segment: 0000000000000000
pei_loongarch_load: kernel_entry: 00000000015dc000
pei_loongarch_load: image_size: 0000000001f30000
pei_loongarch_load: text_offset: 0000000000200000
pei_loongarch_load: phys_offset: 0000000000000000
pei_loongarch_load: PE format: yes
loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
kexec_load: entry = 0x15dc000 flags = 0x1020000
nr_segments = 2
segment[0].buf = 0x7ffff1a04010
segment[0].bufsz = 0x1de9a00
segment[0].mem = 0x200000
segment[0].memsz = 0x1f30000
segment[1].buf = 0x555555b28098
segment[1].bufsz = 0x200
segment[1].mem = 0x2130000
segment[1].memsz = 0x4000
Signed-off-by: WANG Rui <wangrui@loongson.cn>
---
kexec/arch/loongarch/kexec-pei-loongarch.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kexec/arch/loongarch/kexec-pei-loongarch.c b/kexec/arch/loongarch/kexec-pei-loongarch.c
index 1a11103..0ee00d9 100644
--- a/kexec/arch/loongarch/kexec-pei-loongarch.c
+++ b/kexec/arch/loongarch/kexec-pei-loongarch.c
@@ -87,7 +87,8 @@ int pei_loongarch_load(int argc, char **argv, const char *buf,
/* Get kernel entry point */
info->entry = (void *)kernel_entry;
- hole_min = kernel_segment + loongarch_mem.image_size;
+ hole_min = kernel_segment + loongarch_mem.text_offset +
+ loongarch_mem.image_size;
/* Create and initialize elf core header segment */
if (info->kexec_flags & KEXEC_ON_CRASH) {
@@ -100,7 +101,8 @@ int pei_loongarch_load(int argc, char **argv, const char *buf,
}
/* Load the kernel */
- add_segment(info, buf, len, kernel_segment, loongarch_mem.image_size);
+ add_segment(info, buf, len, kernel_segment + loongarch_mem.text_offset,
+ loongarch_mem.image_size);
/* Prepare and load dtb and initrd data */
result = loongarch_load_other_segments(info, hole_min);
--
2.42.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Load vmlinux.efi to the link address
2023-11-24 15:46 [PATCH] LoongArch: Load vmlinux.efi to the link address WANG Rui
@ 2023-11-27 13:46 ` Simon Horman
2023-12-02 10:11 ` WANG Rui
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2023-11-27 13:46 UTC (permalink / raw)
To: WANG Rui; +Cc: kexec, Huacai Chen
On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote:
> Currently, kexec loads vmlinux.efi to address 0 instead of the link
> address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
>
> pei_loongarch_load: kernel_segment: 0000000000000000
> pei_loongarch_load: kernel_entry: 00000000015dc000
> pei_loongarch_load: image_size: 0000000001f30000
> pei_loongarch_load: text_offset: 0000000000200000
> pei_loongarch_load: phys_offset: 0000000000000000
> pei_loongarch_load: PE format: yes
> loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
> kexec_load: entry = 0x15dc000 flags = 0x1020000
> nr_segments = 2
> segment[0].buf = 0x7fffef664010
> segment[0].bufsz = 0x1de9a00
> segment[0].mem = (nil)
> segment[0].memsz = 0x1f30000
> segment[1].buf = 0x555555e480b0
> segment[1].bufsz = 0x200
> segment[1].mem = 0x1f30000
> segment[1].memsz = 0x4000
>
> This patch adds `text_offset` when adding kernel segment to load
> vmlinux.efi to the link address.
>
> pei_loongarch_load: kernel_segment: 0000000000000000
> pei_loongarch_load: kernel_entry: 00000000015dc000
> pei_loongarch_load: image_size: 0000000001f30000
> pei_loongarch_load: text_offset: 0000000000200000
> pei_loongarch_load: phys_offset: 0000000000000000
> pei_loongarch_load: PE format: yes
> loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
> kexec_load: entry = 0x15dc000 flags = 0x1020000
> nr_segments = 2
> segment[0].buf = 0x7ffff1a04010
> segment[0].bufsz = 0x1de9a00
> segment[0].mem = 0x200000
> segment[0].memsz = 0x1f30000
> segment[1].buf = 0x555555b28098
> segment[1].bufsz = 0x200
> segment[1].mem = 0x2130000
> segment[1].memsz = 0x4000
>
> Signed-off-by: WANG Rui <wangrui@loongson.cn>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] LoongArch: Load vmlinux.efi to the link address
2023-11-27 13:46 ` Simon Horman
@ 2023-12-02 10:11 ` WANG Rui
2023-12-02 12:30 ` Huacai Chen
0 siblings, 1 reply; 7+ messages in thread
From: WANG Rui @ 2023-12-02 10:11 UTC (permalink / raw)
To: horms; +Cc: chenhuacai, kexec, wangrui
> On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote:
> > Currently, kexec loads vmlinux.efi to address 0 instead of the link
> > address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
> >
> > pei_loongarch_load: kernel_segment: 0000000000000000
> > pei_loongarch_load: kernel_entry: 00000000015dc000
> > pei_loongarch_load: image_size: 0000000001f30000
> > pei_loongarch_load: text_offset: 0000000000200000
> > pei_loongarch_load: phys_offset: 0000000000000000
> > pei_loongarch_load: PE format: yes
> > loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
> > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > nr_segments = 2
> > segment[0].buf = 0x7fffef664010
> > segment[0].bufsz = 0x1de9a00
> > segment[0].mem = (nil)
> > segment[0].memsz = 0x1f30000
> > segment[1].buf = 0x555555e480b0
> > segment[1].bufsz = 0x200
> > segment[1].mem = 0x1f30000
> > segment[1].memsz = 0x4000
> >
> > This patch adds `text_offset` when adding kernel segment to load
> > vmlinux.efi to the link address.
> >
> > pei_loongarch_load: kernel_segment: 0000000000000000
> > pei_loongarch_load: kernel_entry: 00000000015dc000
> > pei_loongarch_load: image_size: 0000000001f30000
> > pei_loongarch_load: text_offset: 0000000000200000
> > pei_loongarch_load: phys_offset: 0000000000000000
> > pei_loongarch_load: PE format: yes
> > loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
> > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > nr_segments = 2
> > segment[0].buf = 0x7ffff1a04010
> > segment[0].bufsz = 0x1de9a00
> > segment[0].mem = 0x200000
> > segment[0].memsz = 0x1f30000
> > segment[1].buf = 0x555555b28098
> > segment[1].bufsz = 0x200
> > segment[1].mem = 0x2130000
> > segment[1].memsz = 0x4000
> >
> > Signed-off-by: WANG Rui <wangrui@loongson.cn>
>
> Thanks, applied.
Hi Simon,
The patch v1 breaks the real machine. Could you please revert it and just keep v2? Thanks.
- Rui
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] LoongArch: Load vmlinux.efi to the link address
2023-12-02 10:11 ` WANG Rui
@ 2023-12-02 12:30 ` Huacai Chen
2023-12-02 12:46 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Huacai Chen @ 2023-12-02 12:30 UTC (permalink / raw)
To: WANG Rui; +Cc: horms, kexec
On Sat, Dec 2, 2023 at 6:11 PM WANG Rui <wangrui@loongson.cn> wrote:
>
> > On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote:
> > > Currently, kexec loads vmlinux.efi to address 0 instead of the link
> > > address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
> > >
> > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > pei_loongarch_load: image_size: 0000000001f30000
> > > pei_loongarch_load: text_offset: 0000000000200000
> > > pei_loongarch_load: phys_offset: 0000000000000000
> > > pei_loongarch_load: PE format: yes
> > > loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
> > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > nr_segments = 2
> > > segment[0].buf = 0x7fffef664010
> > > segment[0].bufsz = 0x1de9a00
> > > segment[0].mem = (nil)
> > > segment[0].memsz = 0x1f30000
> > > segment[1].buf = 0x555555e480b0
> > > segment[1].bufsz = 0x200
> > > segment[1].mem = 0x1f30000
> > > segment[1].memsz = 0x4000
> > >
> > > This patch adds `text_offset` when adding kernel segment to load
> > > vmlinux.efi to the link address.
> > >
> > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > pei_loongarch_load: image_size: 0000000001f30000
> > > pei_loongarch_load: text_offset: 0000000000200000
> > > pei_loongarch_load: phys_offset: 0000000000000000
> > > pei_loongarch_load: PE format: yes
> > > loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
> > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > nr_segments = 2
> > > segment[0].buf = 0x7ffff1a04010
> > > segment[0].bufsz = 0x1de9a00
> > > segment[0].mem = 0x200000
> > > segment[0].memsz = 0x1f30000
> > > segment[1].buf = 0x555555b28098
> > > segment[1].bufsz = 0x200
> > > segment[1].mem = 0x2130000
> > > segment[1].memsz = 0x4000
> > >
> > > Signed-off-by: WANG Rui <wangrui@loongson.cn>
> >
> > Thanks, applied.
>
> Hi Simon,
>
> The patch v1 breaks the real machine. Could you please revert it and just keep v2? Thanks.
Hmmm, if possible, I suggest resetting the old commit before v1 and
only apply v2... The current status makes the history very very
confusing.
Huacai
>
> - Rui
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] LoongArch: Load vmlinux.efi to the link address
2023-12-02 12:30 ` Huacai Chen
@ 2023-12-02 12:46 ` Simon Horman
2023-12-02 14:03 ` Huacai Chen
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2023-12-02 12:46 UTC (permalink / raw)
To: Huacai Chen; +Cc: WANG Rui, kexec
On Sat, Dec 02, 2023 at 08:30:27PM +0800, Huacai Chen wrote:
> On Sat, Dec 2, 2023 at 6:11 PM WANG Rui <wangrui@loongson.cn> wrote:
> >
> > > On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote:
> > > > Currently, kexec loads vmlinux.efi to address 0 instead of the link
> > > > address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
> > > >
> > > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > > pei_loongarch_load: image_size: 0000000001f30000
> > > > pei_loongarch_load: text_offset: 0000000000200000
> > > > pei_loongarch_load: phys_offset: 0000000000000000
> > > > pei_loongarch_load: PE format: yes
> > > > loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
> > > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > > nr_segments = 2
> > > > segment[0].buf = 0x7fffef664010
> > > > segment[0].bufsz = 0x1de9a00
> > > > segment[0].mem = (nil)
> > > > segment[0].memsz = 0x1f30000
> > > > segment[1].buf = 0x555555e480b0
> > > > segment[1].bufsz = 0x200
> > > > segment[1].mem = 0x1f30000
> > > > segment[1].memsz = 0x4000
> > > >
> > > > This patch adds `text_offset` when adding kernel segment to load
> > > > vmlinux.efi to the link address.
> > > >
> > > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > > pei_loongarch_load: image_size: 0000000001f30000
> > > > pei_loongarch_load: text_offset: 0000000000200000
> > > > pei_loongarch_load: phys_offset: 0000000000000000
> > > > pei_loongarch_load: PE format: yes
> > > > loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
> > > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > > nr_segments = 2
> > > > segment[0].buf = 0x7ffff1a04010
> > > > segment[0].bufsz = 0x1de9a00
> > > > segment[0].mem = 0x200000
> > > > segment[0].memsz = 0x1f30000
> > > > segment[1].buf = 0x555555b28098
> > > > segment[1].bufsz = 0x200
> > > > segment[1].mem = 0x2130000
> > > > segment[1].memsz = 0x4000
> > > >
> > > > Signed-off-by: WANG Rui <wangrui@loongson.cn>
> > >
> > > Thanks, applied.
> >
> > Hi Simon,
> >
> > The patch v1 breaks the real machine. Could you please revert it and just keep v2? Thanks.
> Hmmm, if possible, I suggest resetting the old commit before v1 and
> only apply v2... The current status makes the history very very
> confusing.
Thanks, I would rather not drop patches from the tree as it changes
the hashes of the tree from that point. However, in this case, I agree
that a simple revert makes things confusing, so I have done as you suggest
- v1 has been dropped from the tree.
Can you please check that the tree as of the following commit, which is
now the HEAD commit of the main branch, is correct?
549466430ae6 ("LoongArch: Load vmlinux.efi to the link address")
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Load vmlinux.efi to the link address
2023-12-02 12:46 ` Simon Horman
@ 2023-12-02 14:03 ` Huacai Chen
2023-12-02 16:35 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Huacai Chen @ 2023-12-02 14:03 UTC (permalink / raw)
To: Simon Horman; +Cc: WANG Rui, kexec
On Sat, Dec 2, 2023 at 8:46 PM Simon Horman <horms@kernel.org> wrote:
>
> On Sat, Dec 02, 2023 at 08:30:27PM +0800, Huacai Chen wrote:
> > On Sat, Dec 2, 2023 at 6:11 PM WANG Rui <wangrui@loongson.cn> wrote:
> > >
> > > > On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote:
> > > > > Currently, kexec loads vmlinux.efi to address 0 instead of the link
> > > > > address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
> > > > >
> > > > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > > > pei_loongarch_load: image_size: 0000000001f30000
> > > > > pei_loongarch_load: text_offset: 0000000000200000
> > > > > pei_loongarch_load: phys_offset: 0000000000000000
> > > > > pei_loongarch_load: PE format: yes
> > > > > loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
> > > > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > > > nr_segments = 2
> > > > > segment[0].buf = 0x7fffef664010
> > > > > segment[0].bufsz = 0x1de9a00
> > > > > segment[0].mem = (nil)
> > > > > segment[0].memsz = 0x1f30000
> > > > > segment[1].buf = 0x555555e480b0
> > > > > segment[1].bufsz = 0x200
> > > > > segment[1].mem = 0x1f30000
> > > > > segment[1].memsz = 0x4000
> > > > >
> > > > > This patch adds `text_offset` when adding kernel segment to load
> > > > > vmlinux.efi to the link address.
> > > > >
> > > > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > > > pei_loongarch_load: image_size: 0000000001f30000
> > > > > pei_loongarch_load: text_offset: 0000000000200000
> > > > > pei_loongarch_load: phys_offset: 0000000000000000
> > > > > pei_loongarch_load: PE format: yes
> > > > > loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
> > > > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > > > nr_segments = 2
> > > > > segment[0].buf = 0x7ffff1a04010
> > > > > segment[0].bufsz = 0x1de9a00
> > > > > segment[0].mem = 0x200000
> > > > > segment[0].memsz = 0x1f30000
> > > > > segment[1].buf = 0x555555b28098
> > > > > segment[1].bufsz = 0x200
> > > > > segment[1].mem = 0x2130000
> > > > > segment[1].memsz = 0x4000
> > > > >
> > > > > Signed-off-by: WANG Rui <wangrui@loongson.cn>
> > > >
> > > > Thanks, applied.
> > >
> > > Hi Simon,
> > >
> > > The patch v1 breaks the real machine. Could you please revert it and just keep v2? Thanks.
> > Hmmm, if possible, I suggest resetting the old commit before v1 and
> > only apply v2... The current status makes the history very very
> > confusing.
>
> Thanks, I would rather not drop patches from the tree as it changes
> the hashes of the tree from that point. However, in this case, I agree
> that a simple revert makes things confusing, so I have done as you suggest
> - v1 has been dropped from the tree.
>
> Can you please check that the tree as of the following commit, which is
> now the HEAD commit of the main branch, is correct?
>
> 549466430ae6 ("LoongArch: Load vmlinux.efi to the link address")
Thank you, it is perfect now.
Huacai
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Load vmlinux.efi to the link address
2023-12-02 14:03 ` Huacai Chen
@ 2023-12-02 16:35 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2023-12-02 16:35 UTC (permalink / raw)
To: Huacai Chen; +Cc: WANG Rui, kexec
On Sat, Dec 02, 2023 at 10:03:29PM +0800, Huacai Chen wrote:
> On Sat, Dec 2, 2023 at 8:46 PM Simon Horman <horms@kernel.org> wrote:
> >
> > On Sat, Dec 02, 2023 at 08:30:27PM +0800, Huacai Chen wrote:
> > > On Sat, Dec 2, 2023 at 6:11 PM WANG Rui <wangrui@loongson.cn> wrote:
> > > >
> > > > > On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote:
> > > > > > Currently, kexec loads vmlinux.efi to address 0 instead of the link
> > > > > > address. This causes kexec to fail to boot the new vmlinux.efi on qemu.
> > > > > >
> > > > > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > > > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > > > > pei_loongarch_load: image_size: 0000000001f30000
> > > > > > pei_loongarch_load: text_offset: 0000000000200000
> > > > > > pei_loongarch_load: phys_offset: 0000000000000000
> > > > > > pei_loongarch_load: PE format: yes
> > > > > > loongarch_load_other_segments:333: command_line: kexec console=ttyS0,115200
> > > > > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > > > > nr_segments = 2
> > > > > > segment[0].buf = 0x7fffef664010
> > > > > > segment[0].bufsz = 0x1de9a00
> > > > > > segment[0].mem = (nil)
> > > > > > segment[0].memsz = 0x1f30000
> > > > > > segment[1].buf = 0x555555e480b0
> > > > > > segment[1].bufsz = 0x200
> > > > > > segment[1].mem = 0x1f30000
> > > > > > segment[1].memsz = 0x4000
> > > > > >
> > > > > > This patch adds `text_offset` when adding kernel segment to load
> > > > > > vmlinux.efi to the link address.
> > > > > >
> > > > > > pei_loongarch_load: kernel_segment: 0000000000000000
> > > > > > pei_loongarch_load: kernel_entry: 00000000015dc000
> > > > > > pei_loongarch_load: image_size: 0000000001f30000
> > > > > > pei_loongarch_load: text_offset: 0000000000200000
> > > > > > pei_loongarch_load: phys_offset: 0000000000000000
> > > > > > pei_loongarch_load: PE format: yes
> > > > > > loongarch_load_other_segments:335: command_line: kexec console=ttyS0,115200
> > > > > > kexec_load: entry = 0x15dc000 flags = 0x1020000
> > > > > > nr_segments = 2
> > > > > > segment[0].buf = 0x7ffff1a04010
> > > > > > segment[0].bufsz = 0x1de9a00
> > > > > > segment[0].mem = 0x200000
> > > > > > segment[0].memsz = 0x1f30000
> > > > > > segment[1].buf = 0x555555b28098
> > > > > > segment[1].bufsz = 0x200
> > > > > > segment[1].mem = 0x2130000
> > > > > > segment[1].memsz = 0x4000
> > > > > >
> > > > > > Signed-off-by: WANG Rui <wangrui@loongson.cn>
> > > > >
> > > > > Thanks, applied.
> > > >
> > > > Hi Simon,
> > > >
> > > > The patch v1 breaks the real machine. Could you please revert it and just keep v2? Thanks.
> > > Hmmm, if possible, I suggest resetting the old commit before v1 and
> > > only apply v2... The current status makes the history very very
> > > confusing.
> >
> > Thanks, I would rather not drop patches from the tree as it changes
> > the hashes of the tree from that point. However, in this case, I agree
> > that a simple revert makes things confusing, so I have done as you suggest
> > - v1 has been dropped from the tree.
> >
> > Can you please check that the tree as of the following commit, which is
> > now the HEAD commit of the main branch, is correct?
> >
> > 549466430ae6 ("LoongArch: Load vmlinux.efi to the link address")
> Thank you, it is perfect now.
Thanks for bringing this to my attention and thanks for checking.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-02 16:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-24 15:46 [PATCH] LoongArch: Load vmlinux.efi to the link address WANG Rui
2023-11-27 13:46 ` Simon Horman
2023-12-02 10:11 ` WANG Rui
2023-12-02 12:30 ` Huacai Chen
2023-12-02 12:46 ` Simon Horman
2023-12-02 14:03 ` Huacai Chen
2023-12-02 16:35 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox