Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Coiby Xu <coiby.xu@gmail.com>
To: kexec@lists.infradead.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	Baoquan He <baoquan.he@linux.dev>,
	Dave Young <ruirui.yang@linux.dev>,
	Pratyush Yadav <pratyush@kernel.org>
Subject: [PATCH v3 00/10] Bug fixes and enhancements for kdump LUKS support
Date: Wed, 29 Jul 2026 11:36:40 +0800	[thread overview]
Message-ID: <20260729033654.311541-1-coiby.xu@gmail.com> (raw)

Hi all,

This patch set brings some stability fixes and improvements to the
recently introduced CONFIG_CRASH_DM_CRYPT feature [1][2] (which is to
support LUKS-encrypted device dump target),
  1. address several memory management issues
  2. fix race conditions like configfs writing happens concurrently with
     kexec_file_load syscall
  3. improve configfs handling
  4. update documentation 

To help kernel bots test the patch set, a dependent patch [3] already
applied to the kexec-fixes branch of liveupdate/linux.git tree [4] is
also included.

v3
- Changes suggested by Sourabh
   - more robust check on crash hotplug support
   - use configfs mutex when writing to crash_dm_crypt_keys/restore
   - warn the user when keys have been restored
- Drop patch "crash_dump: Release reference to a keyring at correct
  time" since Guangshuo's version [3] is a more complete fix
- Adjust layout of documentation for crash hotplug support
- Check return codes of the function that
  restore_dm_crypt_keys_to_thread_keyring calls 

v2
 - A different way to address potential double and UAF issues
 - Address several issues [5] scrutinized by Sourabh based on
   Sashiko's review feedback [6] on v1 patch
 - Other improvements like logging fix and doc updates

[1] http://lists.infradead.org/pipermail/kexec/2025-February/031850.html
[2] https://lore.kernel.org/all/20260225060347.718905-1-coxu@redhat.com/
[3] https://lore.kernel.org/all/20260704112509.3717884-1-lgs201920130244@gmail.com
[4] https://git.kernel.org/pub/scm/linux/kernel/git/liveupdate/linux.git/log/?h=kexec-fixes
[5] https://lore.kernel.org/all/972b9a73-d066-4a38-8a4b-fe7d1ba2944b@linux.ibm.com/
[6] https://sashiko.dev/#/patchset/20260403100126.1468200-1-coxu%40redhat.com


Coiby Xu (9):
  crash_dump: Fix potential double free and UAF of keys_header
  crash_dump: Disallow writing to dm-crypt configfs during
    kexec_file_load syscall
  crash_dump: Read the number of dm-crypt keys from reserved memory
  crash_dump: Free temporary dm-crypt keys_header buffer in kdump kernel
  crash_dump: Only use kexec_dprintk during the kexec_file_load syscall
  crash_dump: Improve readability of config_keys_restore_store
  crash_dump: Check the function return codes in
    restore_dm_crypt_keys_to_thread_keyring
  crash_dump: Disallow configfs/crash_dm_crypt_key/reuse if crash
    hotplug supported
  Documentation: kdump: Add arm64 and ppc64le to encrypted dump target
    support list

Guangshuo Li (1):
  crash_dump: release keyring reference at the correct time

 Documentation/admin-guide/kdump/kdump.rst |  20 ++-
 include/linux/kexec.h                     |   6 +
 kernel/crash_dump_dm_crypt.c              | 189 ++++++++++++++++------
 kernel/kexec_file.c                       |   2 +
 4 files changed, 163 insertions(+), 54 deletions(-)


base-commit: f5098b6bae761e346ebcd9da7f95622c04733cff
-- 
2.55.0



             reply	other threads:[~2026-07-29  3:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  3:36 Coiby Xu [this message]
2026-07-29  3:36 ` [PATCH v3 01/10] crash_dump: release keyring reference at the correct time Coiby Xu
2026-07-29  3:36 ` [PATCH v3 02/10] crash_dump: Fix potential double free and UAF of keys_header Coiby Xu
2026-07-29  3:36 ` [PATCH v3 03/10] crash_dump: Disallow writing to dm-crypt configfs during kexec_file_load syscall Coiby Xu
2026-08-05 10:30   ` Sourabh Jain
2026-08-06  5:20     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 04/10] crash_dump: Read the number of dm-crypt keys from reserved memory Coiby Xu
2026-08-05 11:05   ` Sourabh Jain
2026-08-06  6:20     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 05/10] crash_dump: Free temporary dm-crypt keys_header buffer in kdump kernel Coiby Xu
2026-08-05 11:20   ` Sourabh Jain
2026-07-29  3:36 ` [PATCH v3 06/10] crash_dump: Only use kexec_dprintk during the kexec_file_load syscall Coiby Xu
2026-08-05 11:36   ` Sourabh Jain
2026-08-06  5:27     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 07/10] crash_dump: Improve readability of config_keys_restore_store Coiby Xu
2026-08-05 11:52   ` Sourabh Jain
2026-08-06  6:26     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 08/10] crash_dump: Check the function return codes in restore_dm_crypt_keys_to_thread_keyring Coiby Xu
2026-08-05 12:03   ` Sourabh Jain
2026-07-29  3:36 ` [PATCH v3 09/10] crash_dump: Disallow configfs/crash_dm_crypt_key/reuse if crash hotplug supported Coiby Xu
2026-08-05 12:09   ` Sourabh Jain
2026-08-06  5:33     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 10/10] Documentation: kdump: Add arm64 and ppc64le to encrypted dump target support list Coiby Xu
2026-08-05 12:10   ` Sourabh Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729033654.311541-1-coiby.xu@gmail.com \
    --to=coiby.xu@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baoquan.he@linux.dev \
    --cc=kexec@lists.infradead.org \
    --cc=pratyush@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=sourabhjain@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox