Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Coiby Xu <coiby.xu@gmail.com>
To: kexec@lists.infradead.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	Baoquan He <baoquan.he@linux.dev>,
	Dave Young <ruirui.yang@linux.dev>,
	Pratyush Yadav <pratyush@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Coiby Xu <coxu@redhat.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 05/10] crash_dump: Free temporary dm-crypt keys_header buffer in kdump kernel
Date: Wed, 29 Jul 2026 11:36:45 +0800	[thread overview]
Message-ID: <20260729033654.311541-6-coiby.xu@gmail.com> (raw)
In-Reply-To: <20260729033654.311541-1-coiby.xu@gmail.com>

Although we expect the system to reboot immediately after vmcore dumping
is finished, it's still good to free the temporary keys_header buffer.

Fixes: 62f17d9df692 ("crash_dump: retrieve dm crypt keys in kdump kernel")
Reported-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 kernel/crash_dump_dm_crypt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c
index a3996208738b..9a64e2d6841b 100644
--- a/kernel/crash_dump_dm_crypt.c
+++ b/kernel/crash_dump_dm_crypt.c
@@ -117,6 +117,7 @@ static int get_keys_from_kdump_reserved_memory(void)
 
 static int restore_dm_crypt_keys_to_thread_keyring(void)
 {
+	struct keys_header *keys_header __free(kfree_sensitive) = NULL;
 	struct dm_crypt_key *key;
 	size_t keys_header_size;
 	key_ref_t keyring_ref;
-- 
2.55.0



  parent reply	other threads:[~2026-07-29  3:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  3:36 [PATCH v3 00/10] Bug fixes and enhancements for kdump LUKS support Coiby Xu
2026-07-29  3:36 ` [PATCH v3 01/10] crash_dump: release keyring reference at the correct time Coiby Xu
2026-07-29  3:36 ` [PATCH v3 02/10] crash_dump: Fix potential double free and UAF of keys_header Coiby Xu
2026-07-29  3:36 ` [PATCH v3 03/10] crash_dump: Disallow writing to dm-crypt configfs during kexec_file_load syscall Coiby Xu
2026-08-05 10:30   ` Sourabh Jain
2026-08-06  5:20     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 04/10] crash_dump: Read the number of dm-crypt keys from reserved memory Coiby Xu
2026-08-05 11:05   ` Sourabh Jain
2026-08-06  6:20     ` Coiby Xu
2026-07-29  3:36 ` Coiby Xu [this message]
2026-08-05 11:20   ` [PATCH v3 05/10] crash_dump: Free temporary dm-crypt keys_header buffer in kdump kernel Sourabh Jain
2026-07-29  3:36 ` [PATCH v3 06/10] crash_dump: Only use kexec_dprintk during the kexec_file_load syscall Coiby Xu
2026-08-05 11:36   ` Sourabh Jain
2026-08-06  5:27     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 07/10] crash_dump: Improve readability of config_keys_restore_store Coiby Xu
2026-08-05 11:52   ` Sourabh Jain
2026-08-06  6:26     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 08/10] crash_dump: Check the function return codes in restore_dm_crypt_keys_to_thread_keyring Coiby Xu
2026-08-05 12:03   ` Sourabh Jain
2026-07-29  3:36 ` [PATCH v3 09/10] crash_dump: Disallow configfs/crash_dm_crypt_key/reuse if crash hotplug supported Coiby Xu
2026-08-05 12:09   ` Sourabh Jain
2026-08-06  5:33     ` Coiby Xu
2026-07-29  3:36 ` [PATCH v3 10/10] Documentation: kdump: Add arm64 and ppc64le to encrypted dump target support list Coiby Xu
2026-08-05 12:10   ` Sourabh Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729033654.311541-6-coiby.xu@gmail.com \
    --to=coiby.xu@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baoquan.he@linux.dev \
    --cc=coxu@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rppt@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=sourabhjain@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox