* [PATCH] liveupdate: Document that retrieve failure is permanent
@ 2026-06-08 18:42 Tarun Sahu
2026-06-09 15:54 ` Pratyush Yadav
0 siblings, 1 reply; 3+ messages in thread
From: Tarun Sahu @ 2026-06-08 18:42 UTC (permalink / raw)
To: Pasha Tatashin, Mike Rapoport, Pratyush Yadav
Cc: linux-kernel, kexec, vipinsh, Tarun Sahu
Signed-off-by: Tarun Sahu <tarunsahu@google.com>
---
include/uapi/linux/liveupdate.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h
index 30bc66ee9436..a564d2bd05c1 100644
--- a/include/uapi/linux/liveupdate.h
+++ b/include/uapi/linux/liveupdate.h
@@ -168,7 +168,8 @@ struct liveupdate_session_preserve_fd {
* associated with the token and populates the @fd field with a new file
* descriptor referencing the restored resource in the current (new) kernel.
* This operation must be performed *before* signaling completion via
- * %LIVEUPDATE_IOCTL_FINISH.
+ * %LIVEUPDATE_IOCTL_FINISH. Once retrieve call is failed, retrieve status
+ * is saved. So it is permanent failure and retry is pointless.
*
* Return: 0 on success, negative error code on failure (e.g., invalid token).
*/
base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce
prerequisite-patch-id: 30753743cdfab5c3c5355ecde725b6648f1b7a17
--
2.54.0.1099.g489fc7bff1-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] liveupdate: Document that retrieve failure is permanent
2026-06-08 18:42 [PATCH] liveupdate: Document that retrieve failure is permanent Tarun Sahu
@ 2026-06-09 15:54 ` Pratyush Yadav
2026-06-11 9:30 ` tarunsahu
0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Yadav @ 2026-06-09 15:54 UTC (permalink / raw)
To: Tarun Sahu
Cc: Pasha Tatashin, Mike Rapoport, Pratyush Yadav, linux-kernel,
kexec, vipinsh
On Mon, Jun 08 2026, Tarun Sahu wrote:
> Signed-off-by: Tarun Sahu <tarunsahu@google.com>
> ---
> include/uapi/linux/liveupdate.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h
> index 30bc66ee9436..a564d2bd05c1 100644
> --- a/include/uapi/linux/liveupdate.h
> +++ b/include/uapi/linux/liveupdate.h
> @@ -168,7 +168,8 @@ struct liveupdate_session_preserve_fd {
> * associated with the token and populates the @fd field with a new file
> * descriptor referencing the restored resource in the current (new) kernel.
> * This operation must be performed *before* signaling completion via
> - * %LIVEUPDATE_IOCTL_FINISH.
> + * %LIVEUPDATE_IOCTL_FINISH. Once retrieve call is failed, retrieve status
> + * is saved. So it is permanent failure and retry is pointless.
Perhaps the wording below is slightly better from a user perspective?
If a retrieve of a token fails, subsequent attempts to retrieve the
token fail with the same error code. Failed retrieves are not
retried.
> *
> * Return: 0 on success, negative error code on failure (e.g., invalid token).
> */
>
> base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce
> prerequisite-patch-id: 30753743cdfab5c3c5355ecde725b6648f1b7a17
--
Regards,
Pratyush Yadav
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] liveupdate: Document that retrieve failure is permanent
2026-06-09 15:54 ` Pratyush Yadav
@ 2026-06-11 9:30 ` tarunsahu
0 siblings, 0 replies; 3+ messages in thread
From: tarunsahu @ 2026-06-11 9:30 UTC (permalink / raw)
To: Pratyush Yadav
Cc: Pasha Tatashin, Mike Rapoport, Pratyush Yadav, linux-kernel,
kexec, vipinsh
Pratyush Yadav <pratyush@kernel.org> writes:
> On Mon, Jun 08 2026, Tarun Sahu wrote:
>
>> Signed-off-by: Tarun Sahu <tarunsahu@google.com>
>> ---
>> include/uapi/linux/liveupdate.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h
>> index 30bc66ee9436..a564d2bd05c1 100644
>> --- a/include/uapi/linux/liveupdate.h
>> +++ b/include/uapi/linux/liveupdate.h
>> @@ -168,7 +168,8 @@ struct liveupdate_session_preserve_fd {
>> * associated with the token and populates the @fd field with a new file
>> * descriptor referencing the restored resource in the current (new) kernel.
>> * This operation must be performed *before* signaling completion via
>> - * %LIVEUPDATE_IOCTL_FINISH.
>> + * %LIVEUPDATE_IOCTL_FINISH. Once retrieve call is failed, retrieve status
>> + * is saved. So it is permanent failure and retry is pointless.
>
> Perhaps the wording below is slightly better from a user perspective?
>
> If a retrieve of a token fails, subsequent attempts to retrieve the
> token fail with the same error code. Failed retrieves are not
> retried.
Updated!
>
>> *
>> * Return: 0 on success, negative error code on failure (e.g., invalid token).
>> */
>>
>> base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce
>> prerequisite-patch-id: 30753743cdfab5c3c5355ecde725b6648f1b7a17
>
> --
> Regards,
> Pratyush Yadav
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-11 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-08 18:42 [PATCH] liveupdate: Document that retrieve failure is permanent Tarun Sahu
2026-06-09 15:54 ` Pratyush Yadav
2026-06-11 9:30 ` tarunsahu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox