From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: kexec@lists.infradead.org
Cc: Simon Horman <horms@verge.net.au>
Subject: [PATCH] x86_64 purgatory Makefile typo fix.
Date: Fri, 14 Mar 2008 14:47:00 +0530 [thread overview]
Message-ID: <47DA428C.3040608@in.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
While trying to test latest kexec tools git code on a x86_64
box i ran into following issue. Kexec refused to load both
kexec and kdump kernels.
# ./build/sbin/kexec -l /boot/vmlinuz-2.6.25-rc5 --initrd=/boot/initrd-2.6.25-rc5
Symbol: entry32_regs not found cannot get
#
# ./build/kexec -p /boot/vmlinux-kdump --initrd=/boot/initrd-kdump
--append="...."
Symbol: entry64_regs not found cannot get
#
It turns out that entry64.S file under purgatory/arch/x86_64 was not
compiled. The original x86_64_PURGATORY_SRCS were being overwritten
in the Makefile.
Here is a patch to fix this issue.
Thanks
-Sachin
[-- Attachment #2: kexec-tools-x86_64_purgatory_makefile_fix.patch --]
[-- Type: text/x-patch, Size: 821 bytes --]
* This patch fixes a typo in x86_64 purgatory makefile
Signed Off By : Sachin Sant (sachinp@in.ibm.com)
---
diff -Naurp old/purgatory/arch/x86_64/Makefile new/purgatory/arch/x86_64/Makefile
--- old/purgatory/arch/x86_64/Makefile 2008-03-07 11:18:10.000000000 +0530
+++ new/purgatory/arch/x86_64/Makefile 2008-03-14 14:24:50.000000000 +0530
@@ -14,7 +14,7 @@ dist += purgatory/arch/x86_64/Makefile $
purgatory/arch/x86_64/purgatory-x86_64.h
# Done add sources in i386/ to dist, as i386/Makefile adds them
-x86_64_PURGATORY_SRCS = purgatory/arch/i386/entry32-16.S
+x86_64_PURGATORY_SRCS += purgatory/arch/i386/entry32-16.S
x86_64_PURGATORY_SRCS += purgatory/arch/i386/entry32-16-debug.S
x86_64_PURGATORY_SRCS += purgatory/arch/i386/crashdump_backup.c
x86_64_PURGATORY_SRCS += purgatory/arch/i386/console-x86.c
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2008-03-14 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 9:17 Sachin P. Sant [this message]
2008-03-14 16:56 ` [PATCH] x86_64 purgatory Makefile typo fix Bernhard Walle
2008-03-17 0:49 ` Simon Horman
2008-03-17 9:07 ` Bernhard Walle
2008-03-18 3:03 ` Simon Horman
2008-03-17 9:16 ` Sachin P. Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DA428C.3040608@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox