Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: kexec@lists.infradead.org
Subject: Re: [PATCH] x86_64 purgatory Makefile typo fix.
Date: Mon, 17 Mar 2008 10:07:36 +0100	[thread overview]
Message-ID: <frlcco$7u5$1@ger.gmane.org> (raw)
In-Reply-To: 20080317004922.GC1433@verge.net.au

Hi Simon,

* Simon Horman [2008-03-17 01:49]:
> 
> Ooops, sorry about that.
> 
> Perhaps this is worthy of a fresh release?

IMO yes since the current release is unusable on x86_64. But please make
sure to also include the

 1. The distribution missed the files

        purgatory/arch/x86_64/entry64-32.S,
        purgatory/arch/x86_64/entry64.S,
        purgatory/arch/x86_64/setup-x86_64.S,
        purgatory/arch/x86_64/stack.S,
        purgatory/arch/x86_64/purgatory-x86_64.c

    The problem was that variable expansion in a Makefile is a bit   
    different from the expectation, i.e. the final value is used even if
    the variable is used in the middle.

part of my fix.


        Bernhard


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2008-03-17  9:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14  9:17 [PATCH] x86_64 purgatory Makefile typo fix Sachin P. Sant
2008-03-14 16:56 ` Bernhard Walle
2008-03-17  0:49 ` Simon Horman
2008-03-17  9:07   ` Bernhard Walle [this message]
2008-03-18  3:03     ` Simon Horman
2008-03-17  9:16   ` Sachin P. Sant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='frlcco$7u5$1@ger.gmane.org' \
    --to=bwalle@suse.de \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox