From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"geoff@infradead.org" <geoff@infradead.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"david.griego@linaro.org" <david.griego@linaro.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"freddy77@gmail.com" <freddy77@gmail.com>
Subject: Re: [v3 1/5] arm64: kvm: add a cpu tear-down function
Date: Thu, 09 Apr 2015 12:53:58 +0900 [thread overview]
Message-ID: <5525F7D6.2040304@linaro.org> (raw)
In-Reply-To: <20150408130221.GA5977@leverpostej>
On 04/08/2015 10:02 PM, Mark Rutland wrote:
>> + /* We're now in idmap, disable MMU */
>> +1: mrs x0, sctlr_el2
>> + and x1, x0, #SCTLR_EL2_EE
>> + orr x0, x0, x1 // preserve endianness of EL2
>> + ldr x1, =SCTLR_EL2_FLAGS
>> + eor x1, x1, xzr
>> + bic x0, x0, x1 // Clear SCTL_M and etc
>> + msr sctlr_el2, x0
>> + isb
>
> This can instead be:
>
> 1: mrs x0, sctlr_el2
> ldr x1, =SCTLR_EL2_FLAGS
> bic x0, x0, x1
> msr sctlr_el2, x0
> isb
>
> As SCTLR_EL2_FLAGS doesn't contain the EE bit.
Oops. I will fix it.
Thanks,
-Takahiro AKASHI
> Mark.
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-04-09 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 5:40 [v3 0/5] arm64: kvm: reset hyp context for kexec AKASHI Takahiro
2015-04-02 5:40 ` [v3 1/5] arm64: kvm: add a cpu tear-down function AKASHI Takahiro
2015-04-08 13:02 ` Mark Rutland
2015-04-09 3:53 ` AKASHI Takahiro [this message]
2015-04-02 5:40 ` [v3 2/5] arm64: kvm: allow EL2 context to be reset on shutdown AKASHI Takahiro
2015-04-08 13:05 ` Mark Rutland
2015-04-09 4:53 ` AKASHI Takahiro
2015-04-09 15:02 ` Mark Rutland
2015-04-10 6:15 ` AKASHI Takahiro
2015-04-15 12:49 ` Mark Rutland
2015-04-02 5:40 ` [v3 3/5] arm64: kvm: add cpu reset hook for cpu hotplug AKASHI Takahiro
2015-04-02 5:40 ` [v3 4/5] arm64: kvm: add cpu reset at module exit AKASHI Takahiro
2015-04-02 5:40 ` [v3 5/5] arm: kvm: add stub implementation for kvm_cpu_reset() AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5525F7D6.2040304@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=Catalin.Marinas@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=Will.Deacon@arm.com \
--cc=broonie@kernel.org \
--cc=christoffer.dall@linaro.org \
--cc=david.griego@linaro.org \
--cc=freddy77@gmail.com \
--cc=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox