Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Cc: Dave Young <dyoung@redhat.com>, Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel
Date: Fri, 9 Dec 2016 16:02:22 +0530	[thread overview]
Message-ID: <76c2d3ff-99f9-5352-e477-343a22030a6a@redhat.com> (raw)
In-Reply-To: <1481273359-1600-1-git-send-email-horms@verge.net.au>



On Friday 09 December 2016 02:19 PM, Simon Horman wrote:
> The ehdr parameter of machine_apply_elf_rel() is used.
> This resolves a build regression.
>
> Cc: Anton Blanchard <anton@samba.org>
> Cc: Dave Young <dyoung@redhat.com>
> Fixes: 4a2ae3a39c64 ("Pass struct mem_sym into machine_apply_elf_rel()")
> Signed-off-by: Simon Horman <horms@verge.net.au>
> ---
>  kexec/arch/ia64/kexec-elf-rel-ia64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/arch/ia64/kexec-elf-rel-ia64.c b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> index f847626b2508..7f7c08cba4b1 100644
> --- a/kexec/arch/ia64/kexec-elf-rel-ia64.c
> +++ b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> @@ -72,7 +72,7 @@ bundle (const uint64_t insn)
>          return insn & ~0xfUL;
>  }
>
> -void machine_apply_elf_rel(struct mem_ehdr *UNUSED(ehdr),
> +void machine_apply_elf_rel(struct mem_ehdr *ehdr,
>  	struct mem_sym *UNUSED(sym), unsigned long r_type, void *location,
>  	unsigned long address, unsigned long value)
>  {
>

Reviewed-by: Pratyush Anand <panand@redhat.com>

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2016-12-09 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09  8:49 [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel Simon Horman
2016-12-09 10:32 ` Pratyush Anand [this message]
2016-12-09 10:54   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76c2d3ff-99f9-5352-e477-343a22030a6a@redhat.com \
    --to=panand@redhat.com \
    --cc=anton@samba.org \
    --cc=dyoung@redhat.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox