From: Simon Horman <horms@verge.net.au>
To: Pratyush Anand <panand@redhat.com>
Cc: Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel
Date: Fri, 9 Dec 2016 11:54:28 +0100 [thread overview]
Message-ID: <20161209105428.GA9789@verge.net.au> (raw)
In-Reply-To: <76c2d3ff-99f9-5352-e477-343a22030a6a@redhat.com>
On Fri, Dec 09, 2016 at 04:02:22PM +0530, Pratyush Anand wrote:
>
>
> On Friday 09 December 2016 02:19 PM, Simon Horman wrote:
> >The ehdr parameter of machine_apply_elf_rel() is used.
> >This resolves a build regression.
> >
> >Cc: Anton Blanchard <anton@samba.org>
> >Cc: Dave Young <dyoung@redhat.com>
> >Fixes: 4a2ae3a39c64 ("Pass struct mem_sym into machine_apply_elf_rel()")
> >Signed-off-by: Simon Horman <horms@verge.net.au>
> >---
> > kexec/arch/ia64/kexec-elf-rel-ia64.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kexec/arch/ia64/kexec-elf-rel-ia64.c b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> >index f847626b2508..7f7c08cba4b1 100644
> >--- a/kexec/arch/ia64/kexec-elf-rel-ia64.c
> >+++ b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> >@@ -72,7 +72,7 @@ bundle (const uint64_t insn)
> > return insn & ~0xfUL;
> > }
> >
> >-void machine_apply_elf_rel(struct mem_ehdr *UNUSED(ehdr),
> >+void machine_apply_elf_rel(struct mem_ehdr *ehdr,
> > struct mem_sym *UNUSED(sym), unsigned long r_type, void *location,
> > unsigned long address, unsigned long value)
> > {
> >
>
> Reviewed-by: Pratyush Anand <panand@redhat.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2016-12-09 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 8:49 [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel Simon Horman
2016-12-09 10:32 ` Pratyush Anand
2016-12-09 10:54 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209105428.GA9789@verge.net.au \
--to=horms@verge.net.au \
--cc=anton@samba.org \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox