* [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel
@ 2016-12-09 8:49 Simon Horman
2016-12-09 10:32 ` Pratyush Anand
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2016-12-09 8:49 UTC (permalink / raw)
To: kexec; +Cc: Simon Horman, Dave Young, Anton Blanchard
The ehdr parameter of machine_apply_elf_rel() is used.
This resolves a build regression.
Cc: Anton Blanchard <anton@samba.org>
Cc: Dave Young <dyoung@redhat.com>
Fixes: 4a2ae3a39c64 ("Pass struct mem_sym into machine_apply_elf_rel()")
Signed-off-by: Simon Horman <horms@verge.net.au>
---
kexec/arch/ia64/kexec-elf-rel-ia64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kexec/arch/ia64/kexec-elf-rel-ia64.c b/kexec/arch/ia64/kexec-elf-rel-ia64.c
index f847626b2508..7f7c08cba4b1 100644
--- a/kexec/arch/ia64/kexec-elf-rel-ia64.c
+++ b/kexec/arch/ia64/kexec-elf-rel-ia64.c
@@ -72,7 +72,7 @@ bundle (const uint64_t insn)
return insn & ~0xfUL;
}
-void machine_apply_elf_rel(struct mem_ehdr *UNUSED(ehdr),
+void machine_apply_elf_rel(struct mem_ehdr *ehdr,
struct mem_sym *UNUSED(sym), unsigned long r_type, void *location,
unsigned long address, unsigned long value)
{
--
2.7.0.rc3.207.g0ac5344
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel
2016-12-09 8:49 [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel Simon Horman
@ 2016-12-09 10:32 ` Pratyush Anand
2016-12-09 10:54 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Anand @ 2016-12-09 10:32 UTC (permalink / raw)
To: Simon Horman, kexec; +Cc: Dave Young, Anton Blanchard
On Friday 09 December 2016 02:19 PM, Simon Horman wrote:
> The ehdr parameter of machine_apply_elf_rel() is used.
> This resolves a build regression.
>
> Cc: Anton Blanchard <anton@samba.org>
> Cc: Dave Young <dyoung@redhat.com>
> Fixes: 4a2ae3a39c64 ("Pass struct mem_sym into machine_apply_elf_rel()")
> Signed-off-by: Simon Horman <horms@verge.net.au>
> ---
> kexec/arch/ia64/kexec-elf-rel-ia64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/arch/ia64/kexec-elf-rel-ia64.c b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> index f847626b2508..7f7c08cba4b1 100644
> --- a/kexec/arch/ia64/kexec-elf-rel-ia64.c
> +++ b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> @@ -72,7 +72,7 @@ bundle (const uint64_t insn)
> return insn & ~0xfUL;
> }
>
> -void machine_apply_elf_rel(struct mem_ehdr *UNUSED(ehdr),
> +void machine_apply_elf_rel(struct mem_ehdr *ehdr,
> struct mem_sym *UNUSED(sym), unsigned long r_type, void *location,
> unsigned long address, unsigned long value)
> {
>
Reviewed-by: Pratyush Anand <panand@redhat.com>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel
2016-12-09 10:32 ` Pratyush Anand
@ 2016-12-09 10:54 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-12-09 10:54 UTC (permalink / raw)
To: Pratyush Anand; +Cc: Dave Young, kexec, Anton Blanchard
On Fri, Dec 09, 2016 at 04:02:22PM +0530, Pratyush Anand wrote:
>
>
> On Friday 09 December 2016 02:19 PM, Simon Horman wrote:
> >The ehdr parameter of machine_apply_elf_rel() is used.
> >This resolves a build regression.
> >
> >Cc: Anton Blanchard <anton@samba.org>
> >Cc: Dave Young <dyoung@redhat.com>
> >Fixes: 4a2ae3a39c64 ("Pass struct mem_sym into machine_apply_elf_rel()")
> >Signed-off-by: Simon Horman <horms@verge.net.au>
> >---
> > kexec/arch/ia64/kexec-elf-rel-ia64.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kexec/arch/ia64/kexec-elf-rel-ia64.c b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> >index f847626b2508..7f7c08cba4b1 100644
> >--- a/kexec/arch/ia64/kexec-elf-rel-ia64.c
> >+++ b/kexec/arch/ia64/kexec-elf-rel-ia64.c
> >@@ -72,7 +72,7 @@ bundle (const uint64_t insn)
> > return insn & ~0xfUL;
> > }
> >
> >-void machine_apply_elf_rel(struct mem_ehdr *UNUSED(ehdr),
> >+void machine_apply_elf_rel(struct mem_ehdr *ehdr,
> > struct mem_sym *UNUSED(sym), unsigned long r_type, void *location,
> > unsigned long address, unsigned long value)
> > {
> >
>
> Reviewed-by: Pratyush Anand <panand@redhat.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-09 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-09 8:49 [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel Simon Horman
2016-12-09 10:32 ` Pratyush Anand
2016-12-09 10:54 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox