* [PATCH] arm64: Set -fno-PIC along with -mcmodel=large
@ 2018-01-07 16:26 David Michael
2018-02-02 23:48 ` Geoff Levand
0 siblings, 1 reply; 6+ messages in thread
From: David Michael @ 2018-01-07 16:26 UTC (permalink / raw)
To: horms; +Cc: kexec
As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
code model is unsupported. This fixes the "sorry, unimplemented"
errors when building with compilers defaulting to -fPIC.
---
Hi,
I'm hitting this error with 2.0.16 on Gentoo:
purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
This change fixes it. Can something like this be applied?
Thanks.
David
purgatory/arch/arm64/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/purgatory/arch/arm64/Makefile b/purgatory/arch/arm64/Makefile
index 636abea..80068ca 100644
--- a/purgatory/arch/arm64/Makefile
+++ b/purgatory/arch/arm64/Makefile
@@ -1,6 +1,7 @@
arm64_PURGATORY_EXTRA_CFLAGS = \
-mcmodel=large \
+ -fno-PIC \
-fno-stack-protector \
-fno-asynchronous-unwind-tables \
-Wundef \
--
2.14.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large
2018-01-07 16:26 [PATCH] arm64: Set -fno-PIC along with -mcmodel=large David Michael
@ 2018-02-02 23:48 ` Geoff Levand
2018-04-12 23:37 ` Geoff Levand
0 siblings, 1 reply; 6+ messages in thread
From: Geoff Levand @ 2018-02-02 23:48 UTC (permalink / raw)
To: David Michael, horms; +Cc: kexec
Hi,
On 01/07/2018 08:26 AM, David Michael wrote:
> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
> code model is unsupported. This fixes the "sorry, unimplemented"
> errors when building with compilers defaulting to -fPIC.
> ---
>
> purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
>
> This change fixes it. Can something like this be applied?
This change seems reasonable considering large model + PIC is unsupported.
Reviewed by: Geoff Levand <geoff@infradead.org>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large
2018-02-02 23:48 ` Geoff Levand
@ 2018-04-12 23:37 ` Geoff Levand
2018-04-18 12:54 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Geoff Levand @ 2018-04-12 23:37 UTC (permalink / raw)
To: horms; +Cc: David Michael, kexec
Hi Simon,
On 02/02/2018 03:48 PM, Geoff Levand wrote:
> Hi,
>
> On 01/07/2018 08:26 AM, David Michael wrote:
>> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
>> code model is unsupported. This fixes the "sorry, unimplemented"
>> errors when building with compilers defaulting to -fPIC.
>> ---
>>
>> purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
>>
>> This change fixes it. Can something like this be applied?
>
> This change seems reasonable considering large model + PIC is unsupported.
>
> Reviewed by: Geoff Levand <geoff@infradead.org>
Could you please merged this fix so arm64 builds work OK on Gentoo
and Gentoo derivatives.
Thanks.
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large
2018-04-12 23:37 ` Geoff Levand
@ 2018-04-18 12:54 ` Simon Horman
2018-04-18 16:45 ` David Michael
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2018-04-18 12:54 UTC (permalink / raw)
To: Geoff Levand; +Cc: David Michael, kexec
On Thu, Apr 12, 2018 at 04:37:25PM -0700, Geoff Levand wrote:
> Hi Simon,
>
> On 02/02/2018 03:48 PM, Geoff Levand wrote:
> > Hi,
> >
> > On 01/07/2018 08:26 AM, David Michael wrote:
> >> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
> >> code model is unsupported. This fixes the "sorry, unimplemented"
> >> errors when building with compilers defaulting to -fPIC.
> >> ---
> >>
> >> purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
> >>
> >> This change fixes it. Can something like this be applied?
> >
> > This change seems reasonable considering large model + PIC is unsupported.
> >
> > Reviewed by: Geoff Levand <geoff@infradead.org>
>
> Could you please merged this fix so arm64 builds work OK on Gentoo
> and Gentoo derivatives.
Sure, but it really ought to have a Signed-off-by line from David.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large
2018-04-18 12:54 ` Simon Horman
@ 2018-04-18 16:45 ` David Michael
2018-04-19 8:21 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: David Michael @ 2018-04-18 16:45 UTC (permalink / raw)
To: Simon Horman; +Cc: Geoff Levand, kexec
On Wed, Apr 18, 2018 at 8:54 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Apr 12, 2018 at 04:37:25PM -0700, Geoff Levand wrote:
>> Hi Simon,
>>
>> On 02/02/2018 03:48 PM, Geoff Levand wrote:
>> > Hi,
>> >
>> > On 01/07/2018 08:26 AM, David Michael wrote:
>> >> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
>> >> code model is unsupported. This fixes the "sorry, unimplemented"
>> >> errors when building with compilers defaulting to -fPIC.
>> >> ---
>> >>
>> >> purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
>> >>
>> >> This change fixes it. Can something like this be applied?
>> >
>> > This change seems reasonable considering large model + PIC is unsupported.
>> >
>> > Reviewed by: Geoff Levand <geoff@infradead.org>
>>
>> Could you please merged this fix so arm64 builds work OK on Gentoo
>> and Gentoo derivatives.
>
> Sure, but it really ought to have a Signed-off-by line from David.
Sorry about that. Should I resend the patch, or can you amend it with
this line?
Signed-off-by: David Michael <david.michael@coreos.com>
Thanks.
David
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large
2018-04-18 16:45 ` David Michael
@ 2018-04-19 8:21 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2018-04-19 8:21 UTC (permalink / raw)
To: David Michael; +Cc: Geoff Levand, kexec
On Wed, Apr 18, 2018 at 12:45:59PM -0400, David Michael wrote:
> On Wed, Apr 18, 2018 at 8:54 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Apr 12, 2018 at 04:37:25PM -0700, Geoff Levand wrote:
> >> Hi Simon,
> >>
> >> On 02/02/2018 03:48 PM, Geoff Levand wrote:
> >> > Hi,
> >> >
> >> > On 01/07/2018 08:26 AM, David Michael wrote:
> >> >> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
> >> >> code model is unsupported. This fixes the "sorry, unimplemented"
> >> >> errors when building with compilers defaulting to -fPIC.
> >> >> ---
> >> >>
> >> >> purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
> >> >>
> >> >> This change fixes it. Can something like this be applied?
> >> >
> >> > This change seems reasonable considering large model + PIC is unsupported.
> >> >
> >> > Reviewed by: Geoff Levand <geoff@infradead.org>
> >>
> >> Could you please merged this fix so arm64 builds work OK on Gentoo
> >> and Gentoo derivatives.
> >
> > Sure, but it really ought to have a Signed-off-by line from David.
>
> Sorry about that. Should I resend the patch, or can you amend it with
> this line?
>
> Signed-off-by: David Michael <david.michael@coreos.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-19 8:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-07 16:26 [PATCH] arm64: Set -fno-PIC along with -mcmodel=large David Michael
2018-02-02 23:48 ` Geoff Levand
2018-04-12 23:37 ` Geoff Levand
2018-04-18 12:54 ` Simon Horman
2018-04-18 16:45 ` David Michael
2018-04-19 8:21 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox