From: "HAGIO KAZUHITO(萩尾 一仁)" <k-hagio-ab@nec.com>
To: Leonidas Spyropoulos <artafinde@archlinux.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] Makefile: Remove version from /usr/share/makedumpfile
Date: Mon, 24 Oct 2022 02:25:09 +0000 [thread overview]
Message-ID: <8952f78a-fec5-e9b2-7823-33e126aa209d@nec.com> (raw)
In-Reply-To: <20221021102459.28070-1-artafinde@archlinux.org>
On 2022/10/21 19:24, Leonidas Spyropoulos wrote:
> Version specific paths doesn't make sense at
> /usr/share/makedumpfile. This assumes you will have only one version
> installed which on a normal system it makes sense and devs can always
> specify different DESTDIR per versions.
>
> Fixes: #10
>
> Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>
Thanks for the patch.
I agree.
The patch [1] introduced the directory with ${VERSION}, but makedumpfile
has backward compatibility and the directory does not have any data that
has version restraint, so I don't see any reason. Also I didn't find any
discussion in the list archive.
I will merge this a few days later if no objection.
Thanks,
Kazu
[1] https://github.com/makedumpfile/makedumpfile/commit/41e1ccfcd57736047a5c52d8096fbcaa255146ec
> ---
> Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 548e5b7..f6ecbe2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -130,6 +130,6 @@ install:
> install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile $(VPATH)makedumpfile-R.pl
> install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8
> install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5
> - mkdir -p ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts
> - install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile-${VERSION}/makedumpfile.conf.sample
> - install -m 644 -t ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts/ $(VPATH)eppic_scripts/*
> + mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts
> + install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile/makedumpfile.conf.sample
> + install -m 644 -t ${DESTDIR}/usr/share/makedumpfile/eppic_scripts/ $(VPATH)eppic_scripts/*
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2022-10-24 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 10:24 [PATCH] Makefile: Remove version from /usr/share/makedumpfile Leonidas Spyropoulos
2022-10-24 2:25 ` HAGIO KAZUHITO(萩尾 一仁) [this message]
2022-10-27 0:40 ` HAGIO KAZUHITO(萩尾 一仁)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8952f78a-fec5-e9b2-7823-33e126aa209d@nec.com \
--to=k-hagio-ab@nec.com \
--cc=artafinde@archlinux.org \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox