Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "HAGIO KAZUHITO(萩尾　一仁)" <k-hagio-ab@nec.com>
To: Leonidas Spyropoulos <artafinde@archlinux.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] Makefile: Remove version from /usr/share/makedumpfile
Date: Thu, 27 Oct 2022 00:40:50 +0000	[thread overview]
Message-ID: <c11dcd13-e146-1ef7-18e2-e03cab19630a@nec.com> (raw)
In-Reply-To: <8952f78a-fec5-e9b2-7823-33e126aa209d@nec.com>

On 2022/10/24 11:25, HAGIO KAZUHITO(萩尾 一仁) wrote:
> On 2022/10/21 19:24, Leonidas Spyropoulos wrote:
>> Version specific paths doesn't make sense at
>> /usr/share/makedumpfile. This assumes you will have only one version
>> installed which on a normal system it makes sense and devs can always
>> specify different DESTDIR per versions.
>>
>> Fixes: #10
>>
>> Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>
> 
> Thanks for the patch.
> 
> I agree.
> 
> The patch [1] introduced the directory with ${VERSION}, but makedumpfile
> has backward compatibility and the directory does not have any data that
> has version restraint, so I don't see any reason.  Also I didn't find any
> discussion in the list archive.
> 
> I will merge this a few days later if no objection.

Applied.
https://github.com/makedumpfile/makedumpfile/commit/f1d84a5d69d81bc7a89aefae504be88df1e50693

Thanks,
Kazu
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2022-10-27  0:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 10:24 [PATCH] Makefile: Remove version from /usr/share/makedumpfile Leonidas Spyropoulos
2022-10-24  2:25 ` HAGIO KAZUHITO(萩尾　一仁)
2022-10-27  0:40   ` HAGIO KAZUHITO(萩尾　一仁) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c11dcd13-e146-1ef7-18e2-e03cab19630a@nec.com \
    --to=k-hagio-ab@nec.com \
    --cc=artafinde@archlinux.org \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox