Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, linux-doc@vger.kernel.org,
	Pawel Moll <pawel.moll@arm.com>, Jonathan Corbet <corbet@lwn.net>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	kexec@lists.infradead.org, Fenghua Yu <fenghua.yu@intel.com>,
	Haren Myneni <hbabu@us.ibm.com>, Rob Herring <robh+dt@kernel.org>,
	Eric Biederman <ebiederm@xmission.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH 12/12] ARM: kexec: fix kexec for Keystone 2
Date: Thu, 28 Apr 2016 10:28:45 +0100	[thread overview]
Message-ID: <E1aviFZ-0000jq-Ex@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20160428092644.GX19428@n2100.arm.linux.org.uk>

Provide kexec with the boot view of memory by overriding the normal
kexec translation functions added in a previous patch.  We also need
to fix a call to memblock in machine_kexec_prepare() so that we
provide it with a running-view physical address rather than a boot-
view physical address.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/include/asm/kexec.h    | 24 ++++++++++++++++++++++++
 arch/arm/kernel/machine_kexec.c |  2 +-
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/kexec.h b/arch/arm/include/asm/kexec.h
index c2b9b4bdec00..1869af6bac5c 100644
--- a/arch/arm/include/asm/kexec.h
+++ b/arch/arm/include/asm/kexec.h
@@ -53,6 +53,30 @@ static inline void crash_setup_regs(struct pt_regs *newregs,
 /* Function pointer to optional machine-specific reinitialization */
 extern void (*kexec_reinit)(void);
 
+static inline unsigned long phys_to_boot_phys(phys_addr_t phys)
+{
+	return phys_to_idmap(phys);
+}
+#define phys_to_boot_phys phys_to_boot_phys
+
+static inline phys_addr_t boot_phys_to_phys(unsigned long entry)
+{
+	return idmap_to_phys(entry);
+}
+#define boot_phys_to_phys boot_phys_to_phys
+
+static inline unsigned long page_to_boot_pfn(struct page *page)
+{
+	return page_to_pfn(page) + (arch_phys_to_idmap_offset >> PAGE_SHIFT);
+}
+#define page_to_boot_pfn page_to_boot_pfn
+
+static inline struct page *boot_pfn_to_page(unsigned long boot_pfn)
+{
+	return pfn_to_page(boot_pfn - (arch_phys_to_idmap_offset >> PAGE_SHIFT));
+}
+#define boot_pfn_to_page boot_pfn_to_page
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* CONFIG_KEXEC */
diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index 59fd0e24c56b..b18c1ea56bed 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -57,7 +57,7 @@ int machine_kexec_prepare(struct kimage *image)
 	for (i = 0; i < image->nr_segments; i++) {
 		current_segment = &image->segment[i];
 
-		if (!memblock_is_region_memory(current_segment->mem,
+		if (!memblock_is_region_memory(idmap_to_phys(current_segment->mem),
 					       current_segment->memsz))
 			return -EINVAL;
 
-- 
2.1.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2016-04-28  9:33 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  9:26 [PATCH 00/12] Fixing TI Keystone2 kexec Russell King - ARM Linux
2016-04-28  9:27 ` [PATCH 01/12] ARM: kexec: fix crashkernel= handling Russell King
2016-04-29 14:17   ` Pratyush Anand
2016-04-28  9:27 ` [PATCH 02/12] ARM: provide improved virt_to_idmap() functionality Russell King
2016-04-28  9:27 ` [PATCH 03/12] ARM: kexec: remove 512MB restriction on kexec crashdump Russell King
2016-04-29 14:19   ` Pratyush Anand
2016-04-29 18:10     ` Russell King - ARM Linux
2016-04-30  3:36       ` Pratyush Anand
2016-04-30  8:25         ` Russell King - ARM Linux
2016-04-28  9:28 ` [PATCH 04/12] ARM: provide arm_has_idmap_alias() helper Russell King
2016-04-29 14:21   ` Pratyush Anand
2016-04-28  9:28 ` [PATCH 05/12] ARM: kdump: advertise boot aliased crash kernel resource Russell King
2016-04-28  9:28 ` [PATCH 06/12] ARM: kexec: advertise location of bootable RAM Russell King
2016-04-29 14:56   ` Pratyush Anand
2016-04-29 18:00     ` Russell King - ARM Linux
2016-04-30  3:27       ` Pratyush Anand
2016-04-30  8:20         ` Russell King - ARM Linux
2016-05-02  7:34           ` Pratyush Anand
2016-05-02 10:10             ` Russell King - ARM Linux
2016-05-02 10:48               ` Pratyush Anand
2016-05-03 10:21     ` [PATCH kexec-tools 01/32] kdump: mmap() and munmap() only work on page-aligned quantites Russell King
2016-05-25  6:16       ` Pratyush Anand
2016-05-26  8:35         ` Russell King - ARM Linux
2016-05-03 10:21     ` [PATCH kexec-tools 02/32] kdump: fix multiple program header entries Russell King
2016-05-25  6:16       ` Pratyush Anand
2016-05-03 10:21     ` [PATCH kexec-tools 03/32] kdump: actually write out the memory Russell King
2016-05-25  6:16       ` Pratyush Anand
2016-05-03 10:21     ` [PATCH kexec-tools 04/32] kdump: fix kdump mapping Russell King
2016-05-25  6:17       ` Pratyush Anand
2016-05-26 14:33         ` Russell King - ARM Linux
2016-05-03 10:21     ` [PATCH kexec-tools 05/32] arm: fix kdump to work on LPAE systems Russell King
2016-05-28 11:28       ` Baoquan He
2016-05-03 10:21     ` [PATCH kexec-tools 06/32] kdump: print mmap() offset in hex Russell King
2016-05-25  6:21       ` Pratyush Anand
2016-05-03 10:21     ` [PATCH kexec-tools 07/32] kexec: fix warnings caused by selecting 64-bit file IO on 32-bit platforms Russell King
2016-05-28 11:33       ` Baoquan He
2016-05-28 13:53         ` Russell King - ARM Linux
2016-05-29 13:29           ` Baoquan He
2016-05-03 10:21     ` [PATCH kexec-tools 08/32] kexec: add max_size to memory_ranges Russell King
2016-05-27 11:43       ` Pratyush Anand
2016-05-03 10:21     ` [PATCH kexec-tools 09/32] kexec: phys_to_virt() must take unsigned long long Russell King
2016-05-25  6:31       ` Pratyush Anand
2016-05-03 10:21     ` [PATCH kexec-tools 10/32] kexec: add generic helper to add to memory_regions Russell King
2016-05-25  8:00       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 11/32] kexec: add mem_regions sorting implementation Russell King
2016-05-25  8:00       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 12/32] kexec: add helper to exlude a region from a set of memory ranges Russell King
2016-05-25  8:00       ` Pratyush Anand
2016-05-26  8:56         ` Russell King - ARM Linux
2016-05-27 15:07           ` Pratyush Anand
2016-05-27 15:12             ` Russell King - ARM Linux
2016-05-03 10:22     ` [PATCH kexec-tools 13/32] arm: fix pointer signedness warning in kexec-uImage-arm.c Russell King
2016-05-25  8:00       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 14/32] arm: fix off-by-one on memory end Russell King
2016-05-25  8:01       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 15/32] arm: fix get_kernel_stext_sym() to close its file Russell King
2016-05-25  8:01       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 16/32] arm: fix ELF32/ELF64 check Russell King
2016-05-03 10:22     ` [PATCH kexec-tools 17/32] arm: return proper error for missing crash kernel Russell King
2016-05-27 11:27       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 18/32] arm: report if crash kernel is out of bounds Russell King
2016-05-27 11:27       ` Pratyush Anand
2016-05-27 13:36         ` Russell King - ARM Linux
2016-05-03 10:22     ` [PATCH kexec-tools 19/32] arm: add memory ranges debug Russell King
2016-05-27 11:28       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 20/32] arm: add maximum number of memory ranges Russell King
2016-05-27 11:29       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 21/32] arm: parse crash_reserved_mem early Russell King
2016-05-27 11:30       ` Pratyush Anand
2016-05-03 10:22     ` [PATCH kexec-tools 22/32] arm: use generic mem_region sorting implementation Russell King
2016-05-27 11:30       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 23/32] arm: move crash system RAM parsing earlier Russell King
2016-05-27 11:33       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 24/32] arm: add support for platforms with boot memory aliases Russell King
2016-05-27 11:34       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 25/32] arm: crashdump needs boot alias of crash kernel region Russell King
2016-05-27 11:34       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 26/32] arm: rename crash_reserved_mem to crash_kernel_mem Russell King
2016-05-27 11:36       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 27/32] arm: add support for multiple reserved regions Russell King
2016-05-27 11:37       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 28/32] arm: add support for boot-time crash kernel resource Russell King
2016-05-27 11:37       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 29/32] arm: add debug of reserved and coredump memory ranges Russell King
2016-05-27 11:35       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 30/32] arm: fix type of phys_offset Russell King
2016-05-27 11:38       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 31/32] arm: clean up phys/page offset debug Russell King
2016-05-27 11:38       ` Pratyush Anand
2016-05-03 10:23     ` [PATCH kexec-tools 32/32] arm: report which ELF core format we will use Russell King
2016-05-27 11:38       ` Pratyush Anand
2016-05-03 10:29     ` [PATCH 06/12] ARM: kexec: advertise location of bootable RAM Russell King - ARM Linux
2016-04-28  9:28 ` [PATCH 07/12] ARM: keystone: dts: add psci command definition Russell King
2016-04-28  9:28 ` [PATCH 08/12] kexec: don't invoke OOM-killer for control page allocation Russell King
2016-04-29 14:57   ` Pratyush Anand
2016-04-28  9:28 ` [PATCH 09/12] kexec: ensure user memory sizes do not wrap Russell King
2016-04-29 14:57   ` Pratyush Anand
2016-04-28  9:28 ` [PATCH 10/12] kexec: arrange for paddr_vmcoreinfo_note() to return phys_addr_t Russell King
2016-04-29 15:06   ` Pratyush Anand
2016-04-29 15:16     ` Mark Rutland
2016-04-29 15:47       ` Pratyush Anand
2016-05-03  4:24         ` Baoquan He
2016-05-03  5:53           ` Pratyush Anand
2016-05-03  9:01             ` Baoquan He
2016-05-03 10:12           ` Russell King - ARM Linux
2016-05-03 12:56             ` Baoquan He
2016-04-29 18:06     ` Russell King - ARM Linux
2016-04-30  3:30       ` Pratyush Anand
2016-04-28  9:28 ` [PATCH 11/12] kexec: allow architectures to override boot mapping Russell King
2016-04-29 15:14   ` Pratyush Anand
2016-04-29 18:08     ` Russell King - ARM Linux
2016-05-11 18:56   ` Russell King - ARM Linux
2016-05-12  6:26   ` Baoquan He
2016-05-12  8:22     ` Russell King - ARM Linux
2016-04-28  9:28 ` Russell King [this message]
2016-04-28 23:04 ` [PATCH 00/12] Fixing TI Keystone2 kexec Simon Horman
2016-05-11  8:29 ` Dave Young
2016-05-11  8:52   ` Russell King - ARM Linux
2016-05-11  9:13     ` Dave Young
2016-05-11  9:32       ` Russell King - ARM Linux
2016-05-11 10:31         ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1aviFZ-0000jq-Ex@rmk-PC.arm.linux.org.uk \
    --to=rmk+kernel@arm.linux.org.uk \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=fenghua.yu@intel.com \
    --cc=galak@codeaurora.org \
    --cc=hbabu@us.ibm.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox