[kexec-tools] Archive file is missed iomem.h file under loongarch architecture.

[kexec-tools] Archive file is missed iomem.h file under loongarch architecture.

[Ming Wang]

Hi,  maintainers,


I get the kexec-tools 2.0.27 from http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz, 

But I noticed that the kexec-tools-2.0.27/kexec/arch/loongarch/iomem.h file was missing from

this archive.


This causes build errors in many distributions, like debian.  The error message is as follows,

make[1]: *** [Makefile:123: kexec/arch/loongarch/crashdump-loongarch.o] Error 1
kexec/arch/loongarch/kexec-loongarch.c:27:10: fatal error: iomem.h: No such file or directory
   27 | #include "iomem.h"

See also: https://buildd.debian.org/status/package.php?p=kexec-tools&suite=sid


Can this archive be repaired and updated?


Thanks,
Ming


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] Archive file is missed iomem.h file under loongarch architecture.

[Simon Horman]

On Mon, Oct 09, 2023 at 05:47:43PM +0800, Ming Wang wrote:
> Hi,  maintainers,
> 
> 
> I get the kexec-tools 2.0.27 from http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz, 
> 
> But I noticed that the kexec-tools-2.0.27/kexec/arch/loongarch/iomem.h file was missing from
> 
> this archive.
> 
> 
> This causes build errors in many distributions, like debian.  The error message is as follows,
> 
> make[1]: *** [Makefile:123: kexec/arch/loongarch/crashdump-loongarch.o] Error 1
> kexec/arch/loongarch/kexec-loongarch.c:27:10: fatal error: iomem.h: No such file or directory
>    27 | #include "iomem.h"
> 
> See also: https://buildd.debian.org/status/package.php?p=kexec-tools&suite=sid
> 
> 
> Can this archive be repaired and updated?
> 
> 
> Thanks, Ming

Hi,

I need to think about how to deal with this from a release PoV.
But can you check if the patch below resolves your problem?

diff --git a/kexec/arch/loongarch/Makefile b/kexec/arch/loongarch/Makefile
index cee7e569a2a2..f91d0baf049a 100644
--- a/kexec/arch/loongarch/Makefile
+++ b/kexec/arch/loongarch/Makefile
@@ -19,5 +19,6 @@ loongarch_VIRT_TO_PHYS =
 dist += kexec/arch/loongarch/Makefile $(loongarch_KEXEC_SRCS)			\
 	kexec/arch/loongarch/kexec-loongarch.h					\
 	kexec/arch/loongarch/image-header.h					\
+	kexec/arch/loongarch/iomem.h						\
 	kexec/arch/loongarch/crashdump-loongarch.h				\
 	kexec/arch/loongarch/include/arch/options.h

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] Archive file is missed iomem.h file under loongarch architecture.

[Ming Wang]

Hi, Simon

Thank you for your reply.

On 10/10/23 21:01, Simon Horman wrote:
> On Mon, Oct 09, 2023 at 05:47:43PM +0800, Ming Wang wrote:
>> Hi,  maintainers,
>>
>>
>> I get the kexec-tools 2.0.27 from http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz, 
>>
>> But I noticed that the kexec-tools-2.0.27/kexec/arch/loongarch/iomem.h file was missing from
>>
>> this archive.
>>
>>
>> This causes build errors in many distributions, like debian.  The error message is as follows,
>>
>> make[1]: *** [Makefile:123: kexec/arch/loongarch/crashdump-loongarch.o] Error 1
>> kexec/arch/loongarch/kexec-loongarch.c:27:10: fatal error: iomem.h: No such file or directory
>>    27 | #include "iomem.h"
>>
>> See also: https://buildd.debian.org/status/package.php?p=kexec-tools&suite=sid
>>
>>
>> Can this archive be repaired and updated?
>>
>>
>> Thanks, Ming
> Hi,
>
> I need to think about how to deal with this from a release PoV.
> But can you check if the patch below resolves your problem?

Thanks for the patch, I think this patch is necessary.


But it doesn't solve my problem. My purpose is to port the loongarch architecture
kexec-tools tool to Debian.

However,debian community's automatic build system pulled the source from
http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz


So, my problem may still require updating the archive.
But I can wait for version 2.0.8 then continuing the debian porting work.

Should this problem be fixed in 2.0.28?

>
> diff --git a/kexec/arch/loongarch/Makefile b/kexec/arch/loongarch/Makefile
> index cee7e569a2a2..f91d0baf049a 100644
> --- a/kexec/arch/loongarch/Makefile
> +++ b/kexec/arch/loongarch/Makefile
> @@ -19,5 +19,6 @@ loongarch_VIRT_TO_PHYS =
>  dist += kexec/arch/loongarch/Makefile $(loongarch_KEXEC_SRCS)			\
>  	kexec/arch/loongarch/kexec-loongarch.h					\
>  	kexec/arch/loongarch/image-header.h					\
> +	kexec/arch/loongarch/iomem.h						\
>  	kexec/arch/loongarch/crashdump-loongarch.h				\
>  	kexec/arch/loongarch/include/arch/options.h


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] Archive file is missed iomem.h file under loongarch architecture.

[Ming Wang]

Hi, Simon

On 10/10/23 21:01, Simon Horman wrote:
> On Mon, Oct 09, 2023 at 05:47:43PM +0800, Ming Wang wrote:
>> Hi,  maintainers,
>>
>>
>> I get the kexec-tools 2.0.27 from http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz, 
>>
>> But I noticed that the kexec-tools-2.0.27/kexec/arch/loongarch/iomem.h file was missing from
>>
>> this archive.
>>
>>
>> This causes build errors in many distributions, like debian.  The error message is as follows,
>>
>> make[1]: *** [Makefile:123: kexec/arch/loongarch/crashdump-loongarch.o] Error 1
>> kexec/arch/loongarch/kexec-loongarch.c:27:10: fatal error: iomem.h: No such file or directory
>>    27 | #include "iomem.h"
>>
>> See also: https://buildd.debian.org/status/package.php?p=kexec-tools&suite=sid
>>
>>
>> Can this archive be repaired and updated?
>>
>>
>> Thanks, Ming
> Hi,
>
> I need to think about how to deal with this from a release PoV.
> But can you check if the patch below resolves your problem?
>
> diff --git a/kexec/arch/loongarch/Makefile b/kexec/arch/loongarch/Makefile
> index cee7e569a2a2..f91d0baf049a 100644
> --- a/kexec/arch/loongarch/Makefile
> +++ b/kexec/arch/loongarch/Makefile
> @@ -19,5 +19,6 @@ loongarch_VIRT_TO_PHYS =
>  dist += kexec/arch/loongarch/Makefile $(loongarch_KEXEC_SRCS)			\
>  	kexec/arch/loongarch/kexec-loongarch.h					\
>  	kexec/arch/loongarch/image-header.h					\
> +	kexec/arch/loongarch/iomem.h						\
>  	kexec/arch/loongarch/crashdump-loongarch.h				\
>  	kexec/arch/loongarch/include/arch/options.h

Add this patch and then make dist, it's OK.

Sorry, I was stupid. This can  fix the problem of missing files.




_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec