* Re: linux-next: Tree for Dec 1 (riscv, crash_core)
[not found] <20231201133726.4a4413dd@canb.auug.org.au>
@ 2023-12-01 19:53 ` Randy Dunlap
2023-12-02 2:22 ` Baoquan He
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-12-01 19:53 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-riscv, kexec, Baoquan He
On 11/30/23 18:37, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20231130:
>
on riscv 32-bit or 64-bit, with
# CONFIG_MMU is not set
In file included from ../arch/riscv/kernel/crash_core.c:3:
../arch/riscv/kernel/crash_core.c: In function 'arch_crash_save_vmcoreinfo':
../arch/riscv/kernel/crash_core.c:8:27: error: 'VA_BITS' undeclared (first use in this function)
8 | VMCOREINFO_NUMBER(VA_BITS);
| ^~~~~~~
../include/linux/crash_core.h:78:64: note: in definition of macro 'VMCOREINFO_NUMBER'
78 | vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name)
| ^~~~
../arch/riscv/kernel/crash_core.c:8:27: note: each undeclared identifier is reported only once for each function it appears in
8 | VMCOREINFO_NUMBER(VA_BITS);
| ^~~~~~~
../include/linux/crash_core.h:78:64: note: in definition of macro 'VMCOREINFO_NUMBER'
78 | vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name)
| ^~~~
../arch/riscv/kernel/crash_core.c:12:58: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'int' [-Wformat=]
12 | vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
| ~~^
| |
| long unsigned int
| %x
../arch/riscv/kernel/crash_core.c:14:64: error: 'VMEMMAP_START' undeclared (first use in this function)
14 | vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
| ^~~~~~~~~~~~~
../arch/riscv/kernel/crash_core.c:15:62: error: 'VMEMMAP_END' undeclared (first use in this function); did you mean 'MEMREMAP_ENC'?
15 | vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
| ^~~~~~~~~~~
| MEMREMAP_ENC
64-bit only:
../arch/riscv/kernel/crash_core.c:17:64: error: 'MODULES_VADDR' undeclared (first use in this function)
17 | vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
| ^~~~~~~~~~~~~
../arch/riscv/kernel/crash_core.c:18:62: error: 'MODULES_END' undeclared (first use in this function)
18 | vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
| ^~~~~~~~~~~
--
~Randy
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Dec 1 (riscv, crash_core)
2023-12-01 19:53 ` linux-next: Tree for Dec 1 (riscv, crash_core) Randy Dunlap
@ 2023-12-02 2:22 ` Baoquan He
2023-12-02 4:55 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Baoquan He @ 2023-12-02 2:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv, kexec
On 12/01/23 at 11:53am, Randy Dunlap wrote:
>
>
> On 11/30/23 18:37, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231130:
> >
>
> on riscv 32-bit or 64-bit, with
> # CONFIG_MMU is not set
Can you provide your .config so that I reproduce it? Disabling
CONFIG_MMU need find all places where it's selected by other config items.
>
> In file included from ../arch/riscv/kernel/crash_core.c:3:
> ../arch/riscv/kernel/crash_core.c: In function 'arch_crash_save_vmcoreinfo':
> ../arch/riscv/kernel/crash_core.c:8:27: error: 'VA_BITS' undeclared (first use in this function)
> 8 | VMCOREINFO_NUMBER(VA_BITS);
> | ^~~~~~~
> ../include/linux/crash_core.h:78:64: note: in definition of macro 'VMCOREINFO_NUMBER'
> 78 | vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name)
> | ^~~~
> ../arch/riscv/kernel/crash_core.c:8:27: note: each undeclared identifier is reported only once for each function it appears in
> 8 | VMCOREINFO_NUMBER(VA_BITS);
> | ^~~~~~~
> ../include/linux/crash_core.h:78:64: note: in definition of macro 'VMCOREINFO_NUMBER'
> 78 | vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name)
> | ^~~~
> ../arch/riscv/kernel/crash_core.c:12:58: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'int' [-Wformat=]
> 12 | vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
> | ~~^
> | |
> | long unsigned int
> | %x
> ../arch/riscv/kernel/crash_core.c:14:64: error: 'VMEMMAP_START' undeclared (first use in this function)
> 14 | vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
> | ^~~~~~~~~~~~~
> ../arch/riscv/kernel/crash_core.c:15:62: error: 'VMEMMAP_END' undeclared (first use in this function); did you mean 'MEMREMAP_ENC'?
> 15 | vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
> | ^~~~~~~~~~~
> | MEMREMAP_ENC
>
> 64-bit only:
>
> ../arch/riscv/kernel/crash_core.c:17:64: error: 'MODULES_VADDR' undeclared (first use in this function)
> 17 | vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
> | ^~~~~~~~~~~~~
> ../arch/riscv/kernel/crash_core.c:18:62: error: 'MODULES_END' undeclared (first use in this function)
> 18 | vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
> | ^~~~~~~~~~~
>
>
>
> --
> ~Randy
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Dec 1 (riscv, crash_core)
2023-12-02 2:22 ` Baoquan He
@ 2023-12-02 4:55 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-12-02 4:55 UTC (permalink / raw)
To: Baoquan He
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv, kexec
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On 12/1/23 18:22, Baoquan He wrote:
> On 12/01/23 at 11:53am, Randy Dunlap wrote:
>>
>>
>> On 11/30/23 18:37, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20231130:
>>>
>>
>> on riscv 32-bit or 64-bit, with
>> # CONFIG_MMU is not set
>
> Can you provide your .config so that I reproduce it? Disabling
> CONFIG_MMU need find all places where it's selected by other config items.
>
Sure. This is for riscv 64-bit.
--
~Randy
[-- Attachment #2: config-r3049.gz --]
[-- Type: application/gzip, Size: 39057 bytes --]
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Dec 1 (riscv, crash_core)
2023-12-04 2:10 Baoquan He
@ 2023-12-04 19:11 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-12-04 19:11 UTC (permalink / raw)
To: Baoquan He
Cc: Stephen Rothwell, akpm, ignat, linux-next, linux-kernel,
linux-riscv, kexec, eric_devolder
Hi,
On 12/3/23 18:10, Baoquan He wrote:
> eric_devolder@yahoo.com, ignat@cloudflare.com,
> Linux Next Mailing List <linux-next@vger.kernel.org>,
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
> linux-riscv <linux-riscv@lists.infradead.org>,
> kexec <kexec@lists.infradead.org>
> Bcc: bhe@redhat.com
> Subject: Re: linux-next: Tree for Dec 1 (riscv, crash_core)
> Reply-To:
> In-Reply-To: <bbd1bbfb-c482-433d-bce9-2b591b8e855e@infradead.org>
>
> On 12/01/23 at 11:53am, Randy Dunlap wrote:
>>
>>
>> On 11/30/23 18:37, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20231130:
>>>
>>
>> on riscv 32-bit or 64-bit, with
>> # CONFIG_MMU is not set
>
[]
> I made two patches to decouple the kexec/crash code with CONFIG_MMU. Not
> sure if risc-v wants that.
>
> Or we can simply add dependency on MMU for ARCH_SUPPORTS_CRASH_DUMP.
> Then when CONFIG_MMU=n, CONFIG_CRASH_DUMP, CONFIG_KEXEC_CORE,
> CONFIG_CRASH_CORE will be unset too. Please help check which one need be
> taken.
>
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 24c1799e2ec4..03d290da7262 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -708,6 +708,7 @@ config ARCH_SUPPORTS_KEXEC_PURGATORY
>
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool y
> + depends on MMU=y
>
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> def_bool CRASH_CORE
>
That works if the RISC-V folks prefer it.
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
--
~Randy
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-12 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231201133726.4a4413dd@canb.auug.org.au>
2023-12-01 19:53 ` linux-next: Tree for Dec 1 (riscv, crash_core) Randy Dunlap
2023-12-02 2:22 ` Baoquan He
2023-12-02 4:55 ` Randy Dunlap
2023-12-04 2:10 Baoquan He
2023-12-04 19:11 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox