Re: [PATCH v12 3/9] kexec: define functions to map and unmap segments

[steven chen <chenste@linux.microsoft.com>]

On 4/21/2025 7:18 AM, Mimi Zohar wrote:
> On Mon, 2025-04-21 at 09:51 -0400, Mimi Zohar wrote:
>> On Fri, 2025-04-18 at 12:36 +0800, Baoquan He wrote:
>>> On 04/15/25 at 07:10pm, steven chen wrote:
>>>> From: Steven Chen <chenste@linux.microsoft.com>
>>>   ^^^^^^
>> As James Bottomley previously explained[1], if you haven't made any changes to
>> Tushar's patch, then the very first line of the patch description would be
>> "From: Tushar Sugandhi <tusharsu@linux.microsoft.com>" followed by a blank line.
>> If there is a minor change, you would add "<your email address>: explanation".
>> For example:
>>
>> Steven Chen <chenste@linux.microsoft.com>: modified patch description
> To clarify: This line would be included below with your Signed-off-by tag.
>
>> [1]
>> https://lore.kernel.org/lkml/58e70121aaee33679ac295847197c1e5511b2a81.camel@HansenPartnership.com/
>>
>>>> Implement kimage_map_segment() to enable IMA to map the measurement log
>>>> list to the kimage structure during the kexec 'load' stage. This function
>>>> gathers the source pages within the specified address range, and maps them
>>>> to a contiguous virtual address range.
>>>>
>>>> This is a preparation for later usage.
>>>>
>>>> Implement kimage_unmap_segment() for unmapping segments using vunmap().
>>>>
>>>> From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
>>>    ^^^^^^
>> Neither "Author:" nor "From:" belong here.  Please remove.
>>
>>>> Signed-off-by: Tushar Sugandhi <tusharsu@linux.microsoft.com>
>>>    ^^^^^^^
>> Having Tushar's "Signed-off-by" tag and yours below indicate that you modified
>> the original author's patch.
> To clarify: "Just" having Tushar's "Signed-off-by" tag and yours below indicate
> that you modified the original author's patch.

Hi Mimi,

I will update it in next version.

Just wandering are you done reviewing or still need more time?

Thanks,

Steven

>>>> Cc: Eric Biederman <ebiederm@xmission.com>
>>>> Cc: Baoquan He <bhe@redhat.com>
>>>> Cc: Vivek Goyal <vgoyal@redhat.com>
>>>> Cc: Dave Young <dyoung@redhat.com>
>>>> Signed-off-by: steven chen <chenste@linux.microsoft.com>
>>>    ^^^^^
>>>
>>> The signing on this patch is a little confusing. I can't see who is the
>>> real author, who is the co-author, between you and Tushar. You may need
>>> to refer to Documentation/process/5.Posting.rst to make that clear.
>>>
>>>> Acked-by: Baoquan He <bhe@redhat.com>