From: Mike Rapoport <rppt@kernel.org>
To: Baoquan He <baoquan.he@linux.dev>
Cc: David Matlack <dmatlack@google.com>,
kexec@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
Dave Young <ruirui.yang@linux.dev>,
Alexander Graf <graf@amazon.com>
Subject: Re: RFC: Enable Sashiko code reviews for kexec@lists.infradead.org
Date: Wed, 2 Sep 2026 11:04:20 +0300 [thread overview]
Message-ID: <apfYhLD0sHt2odi8@kernel.org> (raw)
In-Reply-To: <ape5s5tdwV6WwPih@fedora>
Hi Baoquan,
On Wed, Sep 02, 2026 at 01:52:51PM +0800, Baoquan He wrote:
> On 09/02/26 at 07:34am, Mike Rapoport wrote:
> > On Tue, Sep 01, 2026 at 01:27:34PM -0700, David Matlack wrote:
> > > Hi kexec@ mailing list and maintainers,
> > >
> > > I would like to enable Sashiko code reviews for patches sent to the
> > > kexec mailing list. I have found it useful for patches I have sent and
> > > reviewed on the kvm and linux-pci mailing lists, which have Sashiko
> > > enabled.
> > >
> > > I sent a pull request to Sashiko to add kexec here:
> > >
> > > https://github.com/sashiko-dev/sashiko/pull/474
> >
> > diff --git a/sashiko.dev/email_policy.toml b/sashiko.dev/email_policy.toml
> > index e6e4fb57f..e9ad97708 100644
> > --- a/sashiko.dev/email_policy.toml
> > +++ b/sashiko.dev/email_policy.toml
> > @@ -175,6 +175,12 @@ reply_to_author = false
> > cc_individuals = false
> > cc = ["Chuck Lever <cel@kernel.org>", "Jeff Layton <jlayton@kernel.org>", "Anna Schumaker <anna@kernel.org>"]
> >
> > +[subsystems.kexec]
> > +lists = ["kexec@lists.infradead.org"]
> > +reply_to_author = true
> > +send_positive_review = true
> >
> > Do we really want those?
>
> Some components don't want to CC list, then other people are welcome to
> drop any comment during reviewing, while cc to maintainer and author
> looks good to me. Just an input, no objection to any move.
Sorry, I wasn't clear, I meant do we really want extra emails saying
sashiko is happy?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-09-02 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 20:27 RFC: Enable Sashiko code reviews for kexec@lists.infradead.org David Matlack
2026-09-02 4:34 ` Mike Rapoport
2026-09-02 5:52 ` Baoquan He
2026-09-02 8:04 ` Mike Rapoport [this message]
2026-09-02 8:25 ` Baoquan He
2026-09-02 9:18 ` Pratyush Yadav
2026-09-02 9:53 ` Baoquan He
2026-09-02 17:58 ` David Matlack
2026-09-03 1:02 ` Roman Gushchin
2026-09-02 16:29 ` David Matlack
2026-09-02 17:26 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apfYhLD0sHt2odi8@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baoquan.he@linux.dev \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=ruirui.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox