Re: RFC: Enable Sashiko code reviews for

[Baoquan He <baoquan.he@linux.dev>]

On 09/02/26 at 11:04am, Mike Rapoport wrote:
> Hi Baoquan,
> 
> On Wed, Sep 02, 2026 at 01:52:51PM +0800, Baoquan He wrote:
> > On 09/02/26 at 07:34am, Mike Rapoport wrote:
> > > On Tue, Sep 01, 2026 at 01:27:34PM -0700, David Matlack wrote:
> > > > Hi kexec@ mailing list and maintainers,
> > > > 
> > > > I would like to enable Sashiko code reviews for patches sent to the
> > > > kexec mailing list. I have found it useful for patches I have sent and
> > > > reviewed on the kvm and linux-pci mailing lists, which have Sashiko
> > > > enabled.
> > > > 
> > > > I sent a pull request to Sashiko to add kexec here:
> > > > 
> > > >   https://github.com/sashiko-dev/sashiko/pull/474
> > > 
> > > diff --git a/sashiko.dev/email_policy.toml b/sashiko.dev/email_policy.toml
> > > index e6e4fb57f..e9ad97708 100644
> > > --- a/sashiko.dev/email_policy.toml
> > > +++ b/sashiko.dev/email_policy.toml
> > > @@ -175,6 +175,12 @@ reply_to_author = false
> > >  cc_individuals = false
> > >  cc = ["Chuck Lever <cel@kernel.org>", "Jeff Layton <jlayton@kernel.org>", "Anna Schumaker <anna@kernel.org>"]
> > >  
> > > +[subsystems.kexec]
> > > +lists = ["kexec@lists.infradead.org"]
> > > +reply_to_author = true
> > > +send_positive_review = true
> > > 
> > > Do we really want those?
> > 
> > Some components don't want to CC list, then other people are welcome to
> > drop any comment during reviewing, while cc to maintainer and author
> > looks good to me. Just an input, no objection to any move.
> 
> Sorry, I wasn't clear, I meant do we really want extra emails saying
> sashiko is happy?

Oh, sorry. I misunderstood, I thought you had agreed to introduce
sashiko to part of list/author/maintainer or all.

I think there are two different ways and they have different impact:

1) CC list (CC author and maintainer can be ignored beause all people
can see it)
  This equals to cc author and push other reviewers away. And no
  reviewers will be patient and curious enough to check the sashiko
  report except of maintainers. Because maintainers need pick patch
  and may check if all reported issues are handled;

2) Cc maintainers when patch is cooked
  Maintainers tell patch author to check the report. Maybe CC patch
  author directly can save maintainers' effort. 

I personally think 2) is good. About whether introducing sashiko, 
I would vote yes. I buy token by myself, sashiko would be a plus.

Thanks
Baoquan