From: Anthony Liguori <anthony@codemonkey.ws>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] do not allocate code_gen buffer on ia64
Date: Wed, 24 Sep 2008 15:33:34 +0000 [thread overview]
Message-ID: <48DA5DCE.4020707@codemonkey.ws> (raw)
In-Reply-To: <48DA2465.1040709@sgi.com>
Avi Kivity wrote:
> Jes Sorensen wrote:
>> Avi Kivity wrote:
>>> Jes Sorensen wrote:
>>>> Hi,
>>>>
>>>> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4
>>>> really gets out of hand when you boot say a 64GB guest.
>>>
>>> ia64 doesn't codegen; why not set it to zero?
>>
>> How about this one then?
>>
>
> Applied, thanks. Note qemu uses 4 spaces for intedenation. Talk to
> your editor.
It would seem better to replace #ifdef TARGET_IA64 with if (kvm_enabled()).
If QEMU ever got proper ia64 target support, that's going to be an ugly
bug to find.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-09-24 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 11:28 [patch] do not allocate code_gen buffer on ia64 Jes Sorensen
2008-09-24 11:39 ` Avi Kivity
2008-09-24 11:42 ` Jes Sorensen
2008-09-24 12:09 ` Avi Kivity
2008-09-24 12:52 ` Jes Sorensen
2008-09-24 13:09 ` Avi Kivity
2008-09-24 15:33 ` Anthony Liguori [this message]
2008-09-24 15:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DA5DCE.4020707@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox