Re: [PATCH] [v5] Add gdb break point support to PowerPC kvm

[Jerone Young <jyoung5@us.ibm.com>]

On Mon, 2008-06-09 at 17:56 -0500, Hollis Blanchard wrote:
> On Mon, 2008-06-09 at 16:08 -0500, Jerone Young wrote:
> > 
> > > You also have not addressed the case I pointed out where an IAC
> > matches
> > > after you've programmed it but before you've entered the guest.
> > 
> > Basically can disable them in the dbcr0 before we do any switching out
> > of registers.
> 
> We'll have to enable DBCR0 some time, right?
> 
Yes it gets enabled when when the guest cuts on the bits it wants & the
we restre the host DBCR0.


> > If an IAC is matched before we enter the guest it will be caught host
> > that catches it.
> 
> But that won't happen because you've disabled MSR[DE].

Ah... you don't rember the whole imprecise interrupts ;-) . When MSR[DE]
=0 and an IAC will go off but not at the exact address. This was fun
figuring out.

I also have a bug in this patch. I placed the wrong definitions when
disabling the debug interrupts. I'll respin again. Look things over more
carefully this time.


>