From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: kvm-ppc-devel@lists.sourceforge.net
Subject: Re: [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x
Date: Thu, 10 Apr 2008 13:44:43 +0000 [thread overview]
Message-ID: <200804101544.44457.arnd@arndb.de> (raw)
In-Reply-To: <df0f79b7b4ab628887c2.1207673354@thinkpadL>
On Tuesday 08 April 2008, Jerone Young wrote:
> +static struct sleep_mode modes[] = {
> + { .name = "wait", .entry = &ppc44x_idle },
> + { .name = "spin", .entry = NULL },
> +};
> +
> +int __init ppc44x_idle_init(void)
> +{
> + void *func = modes[current_mode].entry;
> + ppc_md.power_save = func;
> + return 0;
> +}
> +
> +arch_initcall(ppc44x_idle_init);
> +
> +static int __init idle_param(char *p)
> +{
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(modes); i++) {
> + if (!strcmp(modes[i].name, p)) {
> + current_mode = i;
> + break;
> + }
> + }
> +
> + return 0;
> +}
> +
> +early_param("idle", idle_param);
ok, sorry to steal the show again, now that everyone seems to be happy
with the current code, but isn't this equivalent to the simpler
static int __init idle_param(char *p)
{
if (!strcmp(modes[i].name, "spin"))
ppc_md.power_save = NULL;
}
early_param("idle", idle_param);
if you statically initialize the ppc_md.power_save function to ppc44x_idle
in the platform setup files?
Arnd <><
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
next prev parent reply other threads:[~2008-04-10 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 16:49 [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x platforms Jerone Young
2008-04-08 19:43 ` [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x Hollis Blanchard
2008-04-10 11:53 ` Josh Boyer
2008-04-10 13:44 ` Arnd Bergmann [this message]
2008-04-10 20:08 ` Jerone Young
2008-04-11 0:18 ` Arnd Bergmann
2008-04-11 1:02 ` Josh Boyer
2008-04-11 5:31 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804101544.44457.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kvm-ppc-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox