Kernel KVM-PPC virtualization development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: jyoung5@us.ibm.com
Cc: kvm-ppc-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x
Date: Fri, 11 Apr 2008 00:18:22 +0000	[thread overview]
Message-ID: <200804110218.23912.arnd@arndb.de> (raw)
In-Reply-To: <1207858131.26428.4.camel@thinkpadL>

On Thursday 10 April 2008, Jerone Young wrote:
> Well it could be this simple. But the current code leaves a lot more
> room to add different type waits or spins if need be (if they are ever
> needed ... though none off the top of my head at the moment)...but it
> does allow you to create another wait state for whatever reason a lot
> easier.
> 
> So I really don't think this needs to change. Unless everyone really
> feels that it just has to be.

No, it doesn't need to change, the current patch is entirely correct,
just a little bit more complicated than it needs to be, and I try
not to have code in anticipation of something getting more complicated
in the future, you can always add the complexity at the point where you
need it.

> > 
> > static int __init idle_param(char *p)
> > {
> >       if (!strcmp(modes[i].name, "spin"))
> >               ppc_md.power_save = NULL;
> > }
> > early_param("idle", idle_param);
> > 
> > if you statically initialize the ppc_md.power_save function to ppc44x_idle
> > in the platform setup files?
> 
> The idea is to not statically initialize ppc_md.power_save to
> ppc44x_idle in each platform setup file.
> 

Why not? Unlike the platform_initcall, it wouldn't cost anything and your
current code has the same effect in the end, but in a less obvious way.

	Arnd <><

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

  reply	other threads:[~2008-04-11  0:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 16:49 [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x platforms Jerone Young
2008-04-08 19:43 ` [kvm-ppc-devel] [PATCH] [v5] Add idle wait support for 44x Hollis Blanchard
2008-04-10 11:53 ` Josh Boyer
2008-04-10 13:44 ` Arnd Bergmann
2008-04-10 20:08   ` Jerone Young
2008-04-11  0:18     ` Arnd Bergmann [this message]
2008-04-11  1:02       ` Josh Boyer
2008-04-11  5:31       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804110218.23912.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=jyoung5@us.ibm.com \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox