From: Paul Mackerras <paulus@samba.org>
To: Bharat Bhushan <r65777@freescale.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, agraf@suse.de,
scottwood@freescale.com,
Bharat Bhushan <Bharat.Bhushan@freescale.com>
Subject: Re: [PATCH 2/7 v3] Rename EMULATE_DO_PAPR to EMULATE_EXIT_USER
Date: Tue, 09 Apr 2013 22:37:13 +0000 [thread overview]
Message-ID: <20130409223713.GB4456@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1365417138-8202-3-git-send-email-Bharat.Bhushan@freescale.com>
On Mon, Apr 08, 2013 at 04:02:13PM +0530, Bharat Bhushan wrote:
> Instruction emulation return EMULATE_DO_PAPR when it requires
> exit to userspace on book3s. Similar return is required
> for booke. EMULATE_DO_PAPR reads out to be confusing so it is
> renamed to EMULATE_EXIT_USER.
This and the following patch look like an unnecessary and confusing
change to me. If you want an EMULATE_EXIT_USER, why not just add it
and use it in your new code, and leave the EMULATE_DO_PAPR code alone?
Paul.
next prev parent reply other threads:[~2013-04-09 22:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 10:44 [PATCH 0/7 v3] KVM :PPC: Userspace Debug support Bharat Bhushan
2013-04-08 10:44 ` [PATCH 1/7 v3] KVM: PPC: debug stub interface parameter defined Bharat Bhushan
2013-04-08 10:44 ` [PATCH 2/7 v3] Rename EMULATE_DO_PAPR to EMULATE_EXIT_USER Bharat Bhushan
2013-04-08 10:44 ` [PATCH 3/7 v3] KVM: extend EMULATE_EXIT_USER to support different exit reasons Bharat Bhushan
2013-04-08 10:44 ` [PATCH 4/7 v3] booke: exit to user space if emulator request Bharat Bhushan
2013-04-08 10:44 ` [PATCH 5/7 v3] KVM: PPC: exit to user space on "ehpriv" instruction Bharat Bhushan
2013-04-08 10:44 ` [PATCH 6/7 v3] powerpc: export debug register save function for KVM Bharat Bhushan
2013-04-08 10:44 ` [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support Bharat Bhushan
2013-04-26 11:15 ` Alexander Graf
2013-05-02 9:46 ` Bhushan Bharat-R65777
2013-05-02 11:05 ` Alexander Graf
2013-05-02 14:00 ` Bhushan Bharat-R65777
2013-05-02 14:04 ` Alexander Graf
2013-05-03 10:48 ` Bhushan Bharat-R65777
2013-05-03 11:08 ` Alexander Graf
2013-05-03 12:29 ` Alexander Graf
2013-05-03 13:11 ` Bhushan Bharat-R65777
2013-05-03 13:18 ` Alexander Graf
2013-05-06 5:51 ` Bhushan Bharat-R65777
2013-04-09 8:28 ` [PATCH 5/7 v3] KVM: PPC: exit to user space on "ehpriv" instruction tiejun.chen
2013-04-26 10:45 ` Alexander Graf
2013-04-26 10:56 ` tiejun.chen
2013-04-09 22:37 ` Paul Mackerras [this message]
2013-04-10 22:09 ` [PATCH 2/7 v3] Rename EMULATE_DO_PAPR to EMULATE_EXIT_USER Alexander Graf
2013-04-26 13:37 ` [PATCH 0/7 v3] KVM :PPC: Userspace Debug support Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409223713.GB4456@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Bharat.Bhushan@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=r65777@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox