Kernel KVM-PPC virtualization development
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 03/13] KVM: PPC: Ultravisor: Introduce the MSR_S bit
Date: Tue, 22 Jan 2019 23:36:01 +0000	[thread overview]
Message-ID: <20190122233601.GC24333@blackberry> (raw)
In-Reply-To: <1548172784-27414-4-git-send-email-linuxram@us.ibm.com>

On Tue, Jan 22, 2019 at 07:59:34AM -0800, Ram Pai wrote:
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> 
> MSR_S bit enables access to secure memory.

I would like to see a bit more commentary here that explains that the
hypervisor doesn't (and can't) run with the MSR_S bit set, but a
secure guest and the ultravisor do.

> Signed-off-by: Ram Pai <linuxram@us.ibm.com>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>

Nit: signoffs are in the wrong order.

Paul.

      reply	other threads:[~2019-01-22 23:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 15:59 [PATCH 03/13] KVM: PPC: Ultravisor: Introduce the MSR_S bit Ram Pai
2019-01-22 23:36 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122233601.GC24333@blackberry \
    --to=paulus@ozlabs.org \
    --cc=kvm-ppc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox