Re: [kvm-ppc-devel] [PATCH] [4/4] Add userpace tlb access

Re: [kvm-ppc-devel] [PATCH] [4/4] Add userpace tlb access

[Hollis Blanchard]

On Wed, 2008-01-30 at 13:31 +0100, ehrhardt@linux.vnet.ibm.com wrote:
> Subject: [PATCH] [4/4] Add userpace tlb access (userspace)
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> 
> This adds userspace tlb access transporting a single tlb entry to/from
> userspace. It has an index variable passed with the call to specify the tlb
> entry to get/set. For the guest tlb get&set is supported while the shadow
> tlb can only be read from userspace.
> 
> Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>

I think this patch is out-of-date. It uses KVM_GET_TLB/KVM_SET_TLB,
while your earlier patches created KVM_GET_GUEST_TLB/KVM_SET_GUEST_TLB.
Also, the context mentions bambooKVM_init(), which no longer exists
(it's now bamboo_init()).

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [PATCH] [4/4] Add userpace tlb access

[Christian Ehrhardt]

Hollis Blanchard wrote:
> On Wed, 2008-01-30 at 13:31 +0100, ehrhardt@linux.vnet.ibm.com wrote:
>> Subject: [PATCH] [4/4] Add userpace tlb access (userspace)
>> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>>
>> This adds userspace tlb access transporting a single tlb entry to/from
>> userspace. It has an index variable passed with the call to specify the tlb
>> entry to get/set. For the guest tlb get&set is supported while the shadow
>> tlb can only be read from userspace.
>>
>> Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> 
> I think this patch is out-of-date. It uses KVM_GET_TLB/KVM_SET_TLB,
> while your earlier patches created KVM_GET_GUEST_TLB/KVM_SET_GUEST_TLB.
> Also, the context mentions bambooKVM_init(), which no longer exists
> (it's now bamboo_init()).
> 

huh! - how came that there - yes it's old.
I'll resend the right one


-- 

Grüsse / regards, 
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel