Re: [kvm-ppc-devel] [kvm-devel] [PATCH][QEMU] Use a separate device

Re: [kvm-ppc-devel] [kvm-devel] [PATCH][QEMU] Use a separate device

[Hollis Blanchard]

On Wed, 2008-03-12 at 12:38 -0500, Anthony Liguori wrote:
> Part of the feedback we received from Fabrice about the KVM patches
> for QEMU
> is that we should create a separate device for the in-kernel APIC to
> avoid
> having lots of if (kvm_enabled()) within the APIC code that were
> difficult to
> understand why there were needed.
> 
> This patch separates the in-kernel PIT into a separate device.  It
> also
> introduces some configure logic to only compile in support for the
> in-kernel
> PIT if it's available.
> 
> The result of this is that we now only need a single if
> (kvm_enabled()) to
> determine which device to use.  Besides making it more upstream
> friendly, I
> think this makes the code much easier to understand.
> 
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

This patch solves annoying qemu build breakage hitting PowerPC around
struct kvm_pit_state, so that's another vote in favor...

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH][QEMU] Use a separate device

[Anthony Liguori]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Hollis Blanchard wrote:
> This patch solves annoying qemu build breakage hitting PowerPC around
> struct kvm_pit_state, so that's another vote in favor...
>   

I have an updated version of the patch but it's breaking the build b/c 
something fouled up right now with configure.  libkvm pulls in 
linux/kvm.h which wants to pull in linux/compiler.h.  We don't ship a 
linux/compiler.h though so it's pulling from /usr/include/linux which on 
my system doesn't have a compiler.h.

The lack of this header is causing the configure test to fail.  I've 
attached the patch here for you to use and I'll send it out again once I 
figure out the fix for this linux/compiler.h.

Regards,

Anthony Liguori



[-- Attachment #2: qemu:cleanup_pit.patch --]
[-- Type: application/mbox, Size: 13983 bytes --]

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 170 bytes --]

_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH][QEMU] Use a separate device

[Avi Kivity]

Anthony Liguori wrote:
> Hollis Blanchard wrote:
>> This patch solves annoying qemu build breakage hitting PowerPC around
>> struct kvm_pit_state, so that's another vote in favor...
>>   
>
> I have an updated version of the patch but it's breaking the build b/c 
> something fouled up right now with configure.  libkvm pulls in 
> linux/kvm.h which wants to pull in linux/compiler.h.  We don't ship a 
> linux/compiler.h though so it's pulling from /usr/include/linux which 
> on my system doesn't have a compiler.h.
>
> The lack of this header is causing the configure test to fail.  I've 
> attached the patch here for you to use and I'll send it out again once 
> I figure out the fix for this linux/compiler.h.
>

The patch suffers from the same problem as the apic split; the 
save/restore code is needlessly duplicated.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH][QEMU] Use a separate device

[Anthony Liguori]

Avi Kivity wrote:
> Anthony Liguori wrote:
>   
>> Hollis Blanchard wrote:
>>     
>>> This patch solves annoying qemu build breakage hitting PowerPC around
>>> struct kvm_pit_state, so that's another vote in favor...
>>>   
>>>       
>> I have an updated version of the patch but it's breaking the build b/c 
>> something fouled up right now with configure.  libkvm pulls in 
>> linux/kvm.h which wants to pull in linux/compiler.h.  We don't ship a 
>> linux/compiler.h though so it's pulling from /usr/include/linux which 
>> on my system doesn't have a compiler.h.
>>
>> The lack of this header is causing the configure test to fail.  I've 
>> attached the patch here for you to use and I'll send it out again once 
>> I figure out the fix for this linux/compiler.h.
>>
>>     
>
> The patch suffers from the same problem as the apic split; the 
> save/restore code is needlessly duplicated.
>   

The updated patch addresses this problem.  I have to fix the 
linux/compiler.h issue first though before it can be applied or it will 
break the build.

Regards,

Anthony Liguori



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel