Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Christoph Hellwig]

On Mon, Apr 14, 2008 at 03:37:04AM -0500, Jerone Young wrote:
> 2 files changed, 25 insertions(+), 4 deletions(-)
> Makefile  |   21 ++++++++++++++++++++-
> configure |    8 +++++---
> 
> 
> This patch adds ability for kvm-userspace build system to sync needed kernel headers locally without the need of compiled kernel source.

Please just keep a copy of the kernel headers in the userspace tree so
it can be built standalone.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Avi Kivity]

Christoph Hellwig wrote:
> On Mon, Apr 14, 2008 at 03:37:04AM -0500, Jerone Young wrote:
>   
>> 2 files changed, 25 insertions(+), 4 deletions(-)
>> Makefile  |   21 ++++++++++++++++++++-
>> configure |    8 +++++---
>>
>>
>> This patch adds ability for kvm-userspace build system to sync needed kernel headers locally without the need of compiled kernel source.
>>     
>
> Please just keep a copy of the kernel headers in the userspace tree so
> it can be built standalone.
>
>   

The tarballs do contain a copy of the kernel headers; the 'make sync' 
mechanism is for developers to generate the tarballs without keeping the 
sources duplicated in git.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Christoph Hellwig]

On Mon, Apr 14, 2008 at 02:47:16PM +0300, Avi Kivity wrote:
>> Please just keep a copy of the kernel headers in the userspace tree so
>> it can be built standalone.
>>
>>   
>
> The tarballs do contain a copy of the kernel headers; the 'make sync' 
> mechanism is for developers to generate the tarballs without keeping the 
> sources duplicated in git.

It would be nice to just be able to build kvm from git without a kernel
around.  The lack of that is what in fact keeps from hacking kvm
userspace currently.

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Avi Kivity]

Christoph Hellwig wrote:
> It would be nice to just be able to build kvm from git without a kernel
> around.  The lack of that is what in fact keeps from hacking kvm
> userspace currently.
>   

It would be nice, but committing all header changes twice is not so nice 
and error prone as well.

Anyone serious about hacking kvm-userspace would not be deterred by the 
additional clone.

[maybe we can provide an automatically-generated git tree that has only 
the kernel headers?]

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Anthony Liguori]

Jerone Young wrote:
> 2 files changed, 25 insertions(+), 4 deletions(-)
> Makefile  |   21 ++++++++++++++++++++-
> configure |    8 +++++---
>
>
> This patch adds ability for kvm-userspace build system to sync needed kernel headers locally without the need of compiled kernel source.
>   

make sync in kernel/ already does this.  Why not just add PPC support there.

Regards,

Anthony Liguori

> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@ rpmrelease = devel
>  
>  .PHONY: kernel user libkvm qemu bios vgabios extboot clean libfdt
>  
> -all: libkvm qemu
> +all: sync libkvm qemu
>  ifneq '$(filter $(ARCH), x86_64 i386 ia64)' ''
>      all: $(if $(WANT_MODULE), kernel) user
>  endif
> @@ -69,6 +69,24 @@ install:
>  	make -C libkvm DESTDIR="$(DESTDIR)" install
>  	make -C qemu DESTDIR="$(DESTDIR)" install
>  
> +
> +ASM_DIR=$(ARCH)
> +ifneq '$(filter $(ARCH), i386 x86_64)' ''
> +	ASM_DIR=x86
> +endif
> +
> +sync:
> +	mkdir -p $(INCLUDES_DIR)
> +	mkdir -p $(INCLUDES_DIR)/asm-$(ASM_DIR)
> +	mkdir -p $(INCLUDES_DIR)/linux
> +	cp -f $(KERNELDIR)/include/asm-$(ASM_DIR)/kvm*.h \
> +		$(INCLUDES_DIR)/asm-$(ASM_DIR)/
> +	cp -f $(KERNELDIR)/include/linux/kvm*.h \
> +		$(KERNELDIR)/include/linux/compiler*.h \
> +		$(INCLUDES_DIR)/linux
> +	ln -sf  $(INCLUDES_DIR)/asm-$(ASM_DIR) $(INCLUDES_DIR)/asm
> +
> +
>  tmpspec = .tmp.kvm.spec
>  RPMTOPDIR = $$(pwd)/rpmtop
>  
> @@ -99,3 +117,4 @@ clean:
>  
>  distclean: clean
>  	rm -f config.mak user/config.mak
> +	rm -rf $(INCLUDES_DIR)
> diff --git a/configure b/configure
> --- a/configure
> +++ b/configure
> @@ -10,6 +10,7 @@ cross_prefix>  cross_prefix>  arch=`uname -m`
>  target_exec> +local_kernel_includes_dir=$PWD/includes
>  
>  usage() {
>      cat <<-EOF
> @@ -108,16 +109,16 @@ fi
>  fi
>  
>  #configure user dir
> -(cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
> +(cd user; ./configure --prefix="$prefix" \
>            --arch="$arch" \
>            ${cross_prefix:+"--cross-prefix=$cross_prefix"})
>  
>  #configure qemu
>  (cd qemu; ./configure --target-list=$target_exec \
>      --disable-kqemu \
> -    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
> +    --extra-cflags="-I $PWD/../libkvm $qemu_cflags \
> +               -I $local_kernel_includes_dir" \
>      --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
> -    --kernel-path="$libkvm_kerneldir" \
>      --prefix="$prefix" \
>      ${qemu_cc:+"--cc=$qemu_cc"} \
>      ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
> @@ -131,4 +132,5 @@ KERNELDIR=$kerneldir
>  KERNELDIR=$kerneldir
>  WANT_MODULE=$want_module
>  CROSS_COMPILE=$cross_prefix
> +INCLUDES_DIR=$local_kernel_includes_dir
>  EOF
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Anthony Liguori]

Christoph Hellwig wrote:
> On Mon, Apr 14, 2008 at 03:37:04AM -0500, Jerone Young wrote:
>   
>> 2 files changed, 25 insertions(+), 4 deletions(-)
>> Makefile  |   21 ++++++++++++++++++++-
>> configure |    8 +++++---
>>
>>
>> This patch adds ability for kvm-userspace build system to sync needed kernel headers locally without the need of compiled kernel source.
>>     
>
> Please just keep a copy of the kernel headers in the userspace tree so
> it can be built standalone.
>   

This is what make sync in kernel/ does FWIW and what we distribute for 
releases.

Regards,

Anthony Liguori

> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Anthony Liguori]

Avi Kivity wrote:
> Christoph Hellwig wrote:
>   
>> It would be nice to just be able to build kvm from git without a kernel
>> around.  The lack of that is what in fact keeps from hacking kvm
>> userspace currently.
>>   
>>     
>
> It would be nice, but committing all header changes twice is not so nice 
> and error prone as well.
>
> Anyone serious about hacking kvm-userspace would not be deterred by the 
> additional clone.
>
> [maybe we can provide an automatically-generated git tree that has only 
> the kernel headers?]
>   

Then people will simply find something else to complain about :-)

I think as we split libkvm into it's own library and remove the 
dependency of kernel headers from libkvm consumers, this will stop being 
a problem in practice.

Regards,

Anthony Liguori



-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Avi Kivity]

Anthony Liguori wrote:
>
> I think as we split libkvm into it's own library and remove the 
> dependency of kernel headers from libkvm consumers, this will stop 
> being a problem in practice.
>

That will take a while, as there are many structures used for 
libkvm<->user communications which are provided by the kernel headers, 
and our TODO queue is not quite empty.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

Re: [kvm-ppc-devel] [kvm-devel] [PATCH 1 of 4] Add "make sync" to

[Avi Kivity]

Jerone Young wrote:
> 2 files changed, 25 insertions(+), 4 deletions(-)
> Makefile  |   21 ++++++++++++++++++++-
> configure |    8 +++++---
>
>
> This patch adds ability for kvm-userspace build system to sync needed kernel headers locally without the need of compiled kernel source.
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@ rpmrelease = devel
>  
>  .PHONY: kernel user libkvm qemu bios vgabios extboot clean libfdt
>  
> -all: libkvm qemu
> +all: sync libkvm qemu
>   

'all' shouldn't include 'sync', since it's run by end users that have 
just the tarball, not an entire kernel.

>  ifneq '$(filter $(ARCH), x86_64 i386 ia64)' ''
>      all: $(if $(WANT_MODULE), kernel) user
>  endif
> @@ -69,6 +69,24 @@ install:
>  	make -C libkvm DESTDIR="$(DESTDIR)" install
>  	make -C qemu DESTDIR="$(DESTDIR)" install
>  
> +
> +ASM_DIR=$(ARCH)
> +ifneq '$(filter $(ARCH), i386 x86_64)' ''
> +	ASM_DIR=x86
> +endif
> +
> +sync:
> +	mkdir -p $(INCLUDES_DIR)
> +	mkdir -p $(INCLUDES_DIR)/asm-$(ASM_DIR)
> +	mkdir -p $(INCLUDES_DIR)/linux
> +	cp -f $(KERNELDIR)/include/asm-$(ASM_DIR)/kvm*.h \
> +		$(INCLUDES_DIR)/asm-$(ASM_DIR)/
> +	cp -f $(KERNELDIR)/include/linux/kvm*.h \
> +		$(KERNELDIR)/include/linux/compiler*.h \
> +		$(INCLUDES_DIR)/linux
> +	ln -sf  $(INCLUDES_DIR)/asm-$(ASM_DIR) $(INCLUDES_DIR)/asm
> +
> +
>   

Please use the existing infrastructure in kernel/Makefile.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel