* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates [not found] ` <4FCC4BA8.7050900@codemonkey.ws> @ 2012-06-05 0:52 ` Andreas Färber 2012-06-05 1:58 ` Anthony Liguori 0 siblings, 1 reply; 8+ messages in thread From: Andreas Färber @ 2012-06-05 0:52 UTC (permalink / raw) To: Anthony Liguori, Avi Kivity Cc: Jan Kiszka, Marcelo Tosatti, qemu-devel, kvm, Alexander Graf, kvm-ppc Am 04.06.2012 07:46, schrieb Anthony Liguori: > On 05/22/2012 12:37 AM, Avi Kivity wrote: >> Please pull from: >> >> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master > > Pulled. Thanks. This broke the ppc build. Guys, why wasn't this tested? There's only three KVM targets to test compared to the 14 I'm struggling with... Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 0:52 ` [Qemu-devel] [PULL 00/20 1.2] kvm updates Andreas Färber @ 2012-06-05 1:58 ` Anthony Liguori 2012-06-05 2:26 ` Andreas Färber 2012-06-05 7:42 ` Avi Kivity 0 siblings, 2 replies; 8+ messages in thread From: Anthony Liguori @ 2012-06-05 1:58 UTC (permalink / raw) To: Andreas Färber Cc: Avi Kivity, kvm, Jan Kiszka, Marcelo Tosatti, qemu-devel, kvm-ppc, Alexander Graf On 06/05/2012 08:52 AM, Andreas Färber wrote: > Am 04.06.2012 07:46, schrieb Anthony Liguori: >> On 05/22/2012 12:37 AM, Avi Kivity wrote: >>> Please pull from: >>> >>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >> >> Pulled. Thanks. > > This broke the ppc build. Guys, why wasn't this tested? There's only > three KVM targets to test compared to the 14 I'm struggling with... Is build bot running against uq/master? If it's not, maybe we should add it to build bot to catch this sort of thing. Regards, Anthony Liguori > Andreas > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 1:58 ` Anthony Liguori @ 2012-06-05 2:26 ` Andreas Färber 2012-06-05 7:42 ` Avi Kivity 1 sibling, 0 replies; 8+ messages in thread From: Andreas Färber @ 2012-06-05 2:26 UTC (permalink / raw) To: Anthony Liguori, Stefan Hajnoczi, Daniel Gollub Cc: Avi Kivity, kvm, Jan Kiszka, Marcelo Tosatti, qemu-devel, kvm-ppc, Alexander Graf Am 05.06.2012 03:58, schrieb Anthony Liguori: > Is build bot running against uq/master? If it's not, maybe we should > add it to build bot to catch this sort of thing. That's a question for Stefan and Daniel to answer. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 1:58 ` Anthony Liguori 2012-06-05 2:26 ` Andreas Färber @ 2012-06-05 7:42 ` Avi Kivity 2012-06-05 8:10 ` Alexander Graf 2012-06-05 9:02 ` Anthony Liguori 1 sibling, 2 replies; 8+ messages in thread From: Avi Kivity @ 2012-06-05 7:42 UTC (permalink / raw) To: Anthony Liguori Cc: Andreas Färber, kvm, Jan Kiszka, Marcelo Tosatti, qemu-devel, kvm-ppc, Alexander Graf On 06/05/2012 04:58 AM, Anthony Liguori wrote: > On 06/05/2012 08:52 AM, Andreas Färber wrote: >> Am 04.06.2012 07:46, schrieb Anthony Liguori: >>> On 05/22/2012 12:37 AM, Avi Kivity wrote: >>>> Please pull from: >>>> >>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>> >>> Pulled. Thanks. >> >> This broke the ppc build. Guys, why wasn't this tested? There's only >> three KVM targets to test compared to the 14 I'm struggling with... > > Is build bot running against uq/master? If it's not, maybe we should > add it to build bot to catch this sort of thing. A build bot is overkill. I usually do a full build (and autotest), don't know how this was missed. -- error compiling committee.c: too many arguments to function ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 7:42 ` Avi Kivity @ 2012-06-05 8:10 ` Alexander Graf 2012-06-05 8:32 ` Jan Kiszka 2012-06-05 9:02 ` Anthony Liguori 1 sibling, 1 reply; 8+ messages in thread From: Alexander Graf @ 2012-06-05 8:10 UTC (permalink / raw) To: Avi Kivity Cc: kvm@vger.kernel.org, Jan Kiszka, Marcelo Tosatti, qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org, Anthony Liguori, Andreas Färber On 05.06.2012, at 09:42, Avi Kivity <avi@redhat.com> wrote: > On 06/05/2012 04:58 AM, Anthony Liguori wrote: >> On 06/05/2012 08:52 AM, Andreas Färber wrote: >>> Am 04.06.2012 07:46, schrieb Anthony Liguori: >>>> On 05/22/2012 12:37 AM, Avi Kivity wrote: >>>>> Please pull from: >>>>> >>>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>>> >>>> Pulled. Thanks. >>> >>> This broke the ppc build. Guys, why wasn't this tested? There's only >>> three KVM targets to test compared to the 14 I'm struggling with... >> >> Is build bot running against uq/master? If it's not, maybe we should >> add it to build bot to catch this sort of thing. > > A build bot is overkill. I usually do a full build (and autotest), > don't know how this was missed. Not sure why it would be overkill. We have build bots running on more exotic hw (ppc and s390) with kvm available for that exact purpose. They're running either way - all we need to do is enable uq/master and we catch these before the next pull request :). Alex ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 8:10 ` Alexander Graf @ 2012-06-05 8:32 ` Jan Kiszka 0 siblings, 0 replies; 8+ messages in thread From: Jan Kiszka @ 2012-06-05 8:32 UTC (permalink / raw) To: Alexander Graf Cc: Avi Kivity, Anthony Liguori, Andreas Färber, kvm@vger.kernel.org, Marcelo Tosatti, qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org On 2012-06-05 10:10, Alexander Graf wrote: > > > On 05.06.2012, at 09:42, Avi Kivity <avi@redhat.com> wrote: > >> On 06/05/2012 04:58 AM, Anthony Liguori wrote: >>> On 06/05/2012 08:52 AM, Andreas Färber wrote: >>>> Am 04.06.2012 07:46, schrieb Anthony Liguori: >>>>> On 05/22/2012 12:37 AM, Avi Kivity wrote: >>>>>> Please pull from: >>>>>> >>>>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>>>> >>>>> Pulled. Thanks. >>>> >>>> This broke the ppc build. Guys, why wasn't this tested? There's only >>>> three KVM targets to test compared to the 14 I'm struggling with... >>> >>> Is build bot running against uq/master? If it's not, maybe we should >>> add it to build bot to catch this sort of thing. >> >> A build bot is overkill. I usually do a full build (and autotest), >> don't know how this was missed. > > Not sure why it would be overkill. We have build bots running on more exotic hw (ppc and s390) with kvm available for that exact purpose. They're running either way - all we need to do is enable uq/master and we catch these before the next pull request :). I think this makes some sense. uq/master is supposed to be the staging branch for generic and (at least) x86 kvm changes in QEMU. So it should cover at least their builds. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 7:42 ` Avi Kivity 2012-06-05 8:10 ` Alexander Graf @ 2012-06-05 9:02 ` Anthony Liguori 2012-06-05 9:11 ` Avi Kivity 1 sibling, 1 reply; 8+ messages in thread From: Anthony Liguori @ 2012-06-05 9:02 UTC (permalink / raw) To: Avi Kivity Cc: kvm, Jan Kiszka, Marcelo Tosatti, qemu-devel, kvm-ppc, Alexander Graf, Andreas Färber On 06/05/2012 03:42 PM, Avi Kivity wrote: > On 06/05/2012 04:58 AM, Anthony Liguori wrote: >> On 06/05/2012 08:52 AM, Andreas Färber wrote: >>> Am 04.06.2012 07:46, schrieb Anthony Liguori: >>>> On 05/22/2012 12:37 AM, Avi Kivity wrote: >>>>> Please pull from: >>>>> >>>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>>> >>>> Pulled. Thanks. >>> >>> This broke the ppc build. Guys, why wasn't this tested? There's only >>> three KVM targets to test compared to the 14 I'm struggling with... >> >> Is build bot running against uq/master? If it's not, maybe we should >> add it to build bot to catch this sort of thing. > > A build bot is overkill. I usually do a full build (and autotest), > don't know how this was missed. Note that this error is specific to KVM on PowerPC. It doesn't affect qemu-system-ppc64 built on an x86_64 host. Regards, Anthony Liguori > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates 2012-06-05 9:02 ` Anthony Liguori @ 2012-06-05 9:11 ` Avi Kivity 0 siblings, 0 replies; 8+ messages in thread From: Avi Kivity @ 2012-06-05 9:11 UTC (permalink / raw) To: Anthony Liguori Cc: kvm, Jan Kiszka, Marcelo Tosatti, qemu-devel, kvm-ppc, Alexander Graf, Andreas Färber On 06/05/2012 12:02 PM, Anthony Liguori wrote: > On 06/05/2012 03:42 PM, Avi Kivity wrote: >> On 06/05/2012 04:58 AM, Anthony Liguori wrote: >>> On 06/05/2012 08:52 AM, Andreas Färber wrote: >>>> Am 04.06.2012 07:46, schrieb Anthony Liguori: >>>>> On 05/22/2012 12:37 AM, Avi Kivity wrote: >>>>>> Please pull from: >>>>>> >>>>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>>>> >>>>> Pulled. Thanks. >>>> >>>> This broke the ppc build. Guys, why wasn't this tested? There's only >>>> three KVM targets to test compared to the 14 I'm struggling with... >>> >>> Is build bot running against uq/master? If it's not, maybe we should >>> add it to build bot to catch this sort of thing. >> >> A build bot is overkill. I usually do a full build (and autotest), >> don't know how this was missed. > > Note that this error is specific to KVM on PowerPC. It doesn't affect > qemu-system-ppc64 built on an x86_64 host. Ah, okay. In any case I take back my comment about overkill. An extra buildbot run is cheap and overkill is better than underkill. -- error compiling committee.c: too many arguments to function ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-06-05 9:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1337618267-16669-1-git-send-email-avi@redhat.com>
[not found] ` <4FCC4BA8.7050900@codemonkey.ws>
2012-06-05 0:52 ` [Qemu-devel] [PULL 00/20 1.2] kvm updates Andreas Färber
2012-06-05 1:58 ` Anthony Liguori
2012-06-05 2:26 ` Andreas Färber
2012-06-05 7:42 ` Avi Kivity
2012-06-05 8:10 ` Alexander Graf
2012-06-05 8:32 ` Jan Kiszka
2012-06-05 9:02 ` Anthony Liguori
2012-06-05 9:11 ` Avi Kivity
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox