Re: [PATCH 1/9] remove unused files

Re: [PATCH 1/9] remove unused files

[Alexander Graf]

On 10/16/2013 02:52 PM, Gleb Natapov wrote:
> Copying Alex in case he has an opinion about removing powerpc.

I would prefer to see it fixed and actually get unit tests, but the code 
that's there is trivial enough to not really make an impact on that. So 
no real complaints from my side.


Alex

>
> On Mon, Oct 14, 2013 at 06:23:27PM +0200, Andrew Jones wrote:
>> There are several unused files, primarily because powerpc is an unused
>> arch. The exceptions are config-ia64.mak, which is also an unused arch
>> file, lib/fwcfg.c, lib/panic.c, x86/print.h and x86/run-kvm-unit-tests,
>> which are just unused. Remove them all in order to tidy things up.
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> ---
>>   Makefile                   |   8 +-
>>   config-ia64.mak            |   7 -
>>   config-powerpc-440.mak     |  15 -
>>   config-powerpc.mak         |  39 ---
>>   formats                    |  31 --
>>   iotable.c                  |  53 ----
>>   iotable.h                  |  40 ---
>>   kvmtrace.c                 | 706 ---------------------------------------------
>>   kvmtrace_format            | 532 ----------------------------------
>>   lib/fwcfg.c                |  58 ----
>>   lib/libcflat.h             |   1 -
>>   lib/panic.c                |  13 -
>>   lib/powerpc/44x/map.c      |  51 ----
>>   lib/powerpc/44x/timebase.S |  28 --
>>   lib/powerpc/44x/timebase.h |  25 --
>>   lib/powerpc/44x/tlbwe.S    |  29 --
>>   lib/powerpc/io.c           |  35 ---
>>   main-ppc.c                 | 383 ------------------------
>>   powerpc/44x/tlbsx.S        |  33 ---
>>   powerpc/44x/tlbwe.S        |  27 --
>>   powerpc/44x/tlbwe_16KB.S   |  35 ---
>>   powerpc/44x/tlbwe_hole.S   |  27 --
>>   powerpc/cstart.S           |  38 ---
>>   powerpc/exit.c             |  23 --
>>   powerpc/helloworld.c       |  27 --
>>   powerpc/io.S               |  32 --
>>   powerpc/spin.S             |   4 -
>>   powerpc/sprg.S             |   7 -
>>   x86/print.h                |  19 --
>>   x86/run-kvm-unit-tests     |   6 -
>>   30 files changed, 1 insertion(+), 2331 deletions(-)
>>   delete mode 100644 config-ia64.mak
>>   delete mode 100644 config-powerpc-440.mak
>>   delete mode 100644 config-powerpc.mak
>>   delete mode 100644 formats
>>   delete mode 100644 iotable.c
>>   delete mode 100644 iotable.h
>>   delete mode 100644 kvmtrace.c
>>   delete mode 100755 kvmtrace_format
>>   delete mode 100644 lib/fwcfg.c
>>   delete mode 100644 lib/panic.c
>>   delete mode 100644 lib/powerpc/44x/map.c
>>   delete mode 100644 lib/powerpc/44x/timebase.S
>>   delete mode 100644 lib/powerpc/44x/timebase.h
>>   delete mode 100644 lib/powerpc/44x/tlbwe.S
>>   delete mode 100644 lib/powerpc/io.c
>>   delete mode 100644 main-ppc.c
>>   delete mode 100644 powerpc/44x/tlbsx.S
>>   delete mode 100644 powerpc/44x/tlbwe.S
>>   delete mode 100644 powerpc/44x/tlbwe_16KB.S
>>   delete mode 100644 powerpc/44x/tlbwe_hole.S
>>   delete mode 100644 powerpc/cstart.S
>>   delete mode 100644 powerpc/exit.c
>>   delete mode 100644 powerpc/helloworld.c
>>   delete mode 100644 powerpc/io.S
>>   delete mode 100644 powerpc/spin.S
>>   delete mode 100644 powerpc/sprg.S
>>   delete mode 100644 x86/print.h
>>   delete mode 100644 x86/run-kvm-unit-tests
>>
[...]