From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com, agraf@suse.de,
pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 1/2] powerpc: add asm/ppc_asm.h
Date: Tue, 01 Mar 2016 08:30:22 +0000 [thread overview]
Message-ID: <56D5531E.10108@redhat.com> (raw)
In-Reply-To: <1456768146-10136-2-git-send-email-lvivier@redhat.com>
On 29.02.2016 18:49, Laurent Vivier wrote:
> Move LOAD_REG_IMMEDIATE() and LOAD_REG_ADDR()
> from cstart64.S to ppc_asm.h
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> lib/powerpc/asm/ppc_asm.h | 14 ++++++++++++++
> lib/ppc64/asm/ppc_asm.h | 1 +
> powerpc/cstart64.S | 11 +----------
> 3 files changed, 16 insertions(+), 10 deletions(-)
> create mode 100644 lib/powerpc/asm/ppc_asm.h
> create mode 100644 lib/ppc64/asm/ppc_asm.h
>
> diff --git a/lib/powerpc/asm/ppc_asm.h b/lib/powerpc/asm/ppc_asm.h
> new file mode 100644
> index 0000000..f63bb72
> --- /dev/null
> +++ b/lib/powerpc/asm/ppc_asm.h
> @@ -0,0 +1,14 @@
> +#ifndef _ASMPOWERPC_PPC_ASM_H
> +#define _ASMPOWERPC_PPC_ASM_H
> +
> +#define LOAD_REG_IMMEDIATE(reg,expr) \
> + lis reg,(expr)@highest; \
> + ori reg,reg,(expr)@higher; \
> + rldicr reg,reg,32,31; \
> + oris reg,reg,(expr)@h; \
> + ori reg,reg,(expr)@l;
> +
> +#define LOAD_REG_ADDR(reg,name) \
> + ld reg,name@got(r2)
> +
> +#endif /* _ASMPOWERPC_PPC_ASM_H */
> diff --git a/lib/ppc64/asm/ppc_asm.h b/lib/ppc64/asm/ppc_asm.h
> new file mode 100644
> index 0000000..e3929ee
> --- /dev/null
> +++ b/lib/ppc64/asm/ppc_asm.h
> @@ -0,0 +1 @@
> +#include "../../powerpc/asm/ppc_asm.h"
> diff --git a/powerpc/cstart64.S b/powerpc/cstart64.S
> index 4693ba1..6072597 100644
> --- a/powerpc/cstart64.S
> +++ b/powerpc/cstart64.S
> @@ -7,16 +7,7 @@
> */
> #define __ASSEMBLY__
> #include <asm/hcall.h>
> -
> -#define LOAD_REG_IMMEDIATE(reg,expr) \
> - lis reg,(expr)@highest; \
> - ori reg,reg,(expr)@higher; \
> - rldicr reg,reg,32,31; \
> - oris reg,reg,(expr)@h; \
> - ori reg,reg,(expr)@l;
> -
> -#define LOAD_REG_ADDR(reg,name) \
> - ld reg,name@got(r2)
> +#include <asm/ppc_asm.h>
>
> .section .init
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-03-01 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 17:49 [kvm-unit-tests PATCH v3 0/2] powerpc: add little-endian support Laurent Vivier
2016-02-29 17:49 ` [kvm-unit-tests PATCH v3 1/2] powerpc: add asm/ppc_asm.h Laurent Vivier
2016-02-29 18:56 ` Andrew Jones
2016-03-01 8:30 ` Thomas Huth [this message]
2016-02-29 17:49 ` [kvm-unit-tests PATCH v3 2/2] powerpc: select endianness Laurent Vivier
2016-02-29 19:44 ` Andrew Jones
2016-03-01 8:12 ` Laurent Vivier
2016-03-01 8:40 ` Thomas Huth
2016-03-01 8:54 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5531E.10108@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox