Re: [kvm-unit-tests PATCH v3 2/2] powerpc: select endianness

[Thomas Huth <thuth@redhat.com>]

On 29.02.2016 18:49, Laurent Vivier wrote:
> This patch allows to build tests for ppc64 little endian target
> (ppc64le) on big and little endian hosts.
> 
> We add a new parameter to configure to select the endianness of the
> tests (--endian=little or --endian=big).
> 
> I have built and tested big and little endian tests on a little
> endian host, a big endian host, with kvm_hv and kvm_pr, and on
> x86_64 with ppc64 as a TCG target.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  configure                 | 11 +++++++++++
>  lib/powerpc/asm/ppc_asm.h | 19 +++++++++++++++++++
>  lib/ppc64/asm/io.h        |  8 ++++++++
>  powerpc/Makefile.common   |  3 ++-
>  powerpc/Makefile.ppc64    |  9 +++++++--
>  powerpc/cstart64.S        | 20 ++++++++++++++++----
>  6 files changed, 63 insertions(+), 7 deletions(-)

Patch looks fine to me, so when you fixed the two little things that
Andrew mentioned, feel free to add my Reviewed-by.

 Thomas