From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, kvm@vger.kernel.org
Cc: kvm-ppc@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] powerpc/sprs: Test POWER9 specific registers
Date: Fri, 21 Jul 2017 11:32:37 +0000 [thread overview]
Message-ID: <c7b79ffc-2aef-be90-0927-ad62833ffbbc@redhat.com> (raw)
In-Reply-To: <7a00c3e9-685c-ac60-4a83-82cac1347e91@redhat.com>
On 21.07.2017 13:17, Laurent Vivier wrote:
> On 13/07/2017 09:03, Thomas Huth wrote:
>> Most of the SPRS are the same as on POWER8, so we can re-use
>> the PowerISA 2.07 functions and simply amend the additional
>> registers afterwards.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Could you explain why you don't add 144 (TIDR)?
Good catch. That register was not mentioned in the PowerISA version 3.0
A (from November 30, 2015) which I used when writing this patch.
> I don't see 813 and 814 in Power ISA
> Version 3.0 B (March 29, 2017).
They were mentioned in 3.0 A, but indeed seem to be gone in 3.0 B. I'll
update my patch accordingly...
Thanks for the review!
Thomas
prev parent reply other threads:[~2017-07-21 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 7:03 [kvm-unit-tests PATCH] powerpc/sprs: Test POWER9 specific registers Thomas Huth
2017-07-21 11:17 ` Laurent Vivier
2017-07-21 11:32 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7b79ffc-2aef-be90-0927-ad62833ffbbc@redhat.com \
--to=thuth@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox