KVM-RISCV Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: cem@kernel.org <cem@kernel.org>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 4/6] riscv: Enable gen_report() to print the wrong value in case of test failure
Date: Thu, 29 Feb 2024 13:42:10 +0100	[thread overview]
Message-ID: <20240229124246.309304-5-cem@kernel.org> (raw)
In-Reply-To: <20240229124246.309304-1-cem@kernel.org>

From: Carlos Maiolino <cem@kernel.org>

If the test fails because the expected value doesn't match, it's useful to know
what value was actually printed.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 riscv/sbi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/riscv/sbi.c b/riscv/sbi.c
index fa28d7c8..8ad8f375 100644
--- a/riscv/sbi.c
+++ b/riscv/sbi.c
@@ -28,7 +28,12 @@ static bool env_is_defined(const char *env)
 static void gen_report(struct sbiret *ret, long expected)
 {
 	report(!ret->error, "no sbi.error");
-	report(ret->value == expected, "expected sbi.value");
+
+	if (ret->value == expected)
+		report(true, "expected sbi.value");
+	else
+		report(false, "expected sbi.value: %ld - Got: %ld",
+		       expected, ret->value);
 }
 
 static void check_base(void)
-- 
2.43.2



  parent reply	other threads:[~2024-02-29 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 12:42 [PATCH 0/6] Add riscv tests to cover the base extension specs cem
2024-02-29 12:42 ` [PATCH 1/6] riscv: Add test to probe SBI Extension cem
2024-03-01  8:25   ` Andrew Jones
2024-02-29 12:42 ` [PATCH 2/6] riscv: Factor out environment variable check cem
2024-03-01  8:28   ` Andrew Jones
2024-03-04 10:52     ` Carlos Maiolino
2024-02-29 12:42 ` [PATCH 3/6] riscv: Implement test for architecture ID register cem
2024-03-01  8:31   ` Andrew Jones
2024-02-29 12:42 ` cem [this message]
2024-03-01  8:43   ` [PATCH 4/6] riscv: Enable gen_report() to print the wrong value in case of test failure Andrew Jones
2024-03-05  8:05     ` Carlos Maiolino
2024-03-05 12:16       ` Andrew Jones
2024-03-01  8:46   ` Andrew Jones
2024-02-29 12:42 ` [PATCH 5/6] riscv: Test for specific SBI implementation ID cem
2024-03-01  8:45   ` Andrew Jones
2024-02-29 12:42 ` [PATCH 6/6] riscv: Test for a SBI implementation ID range cem
2024-03-01  8:52   ` Andrew Jones
2024-02-29 14:05 ` [PATCH 0/6] Add riscv tests to cover the base extension specs Andrew Jones
2024-02-29 14:12   ` Carlos Maiolino
2024-02-29 15:03     ` Andrew Jones
2024-02-29 15:31       ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229124246.309304-5-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox