* [PATCH 3/4] kvm: qemu: Fix double LIST_REMOVE device
@ 2008-12-10 9:45 Han, Weidong
2008-12-10 10:12 ` Mark McLoughlin
0 siblings, 1 reply; 2+ messages in thread
From: Han, Weidong @ 2008-12-10 9:45 UTC (permalink / raw)
To: 'Avi Kivity'; +Cc: kvm@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
adev will be removed in free_assigned_device, shouldn't remove it in assigned_dev_update_irq.
Signed-off-by: Weidong Han <weidong.han@intel.com>
---
qemu/hw/device-assignment.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index c72c57c..20618a4 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -525,7 +525,6 @@ void assigned_dev_update_irq()
adev->name, strerror(-r));
fprintf(stderr, "Perhaps you are assigning a device "
"that shares an IRQ with another device?\n");
- LIST_REMOVE(adev, next);
free_assigned_device(adev);
adev = next;
continue;
--
1.6.0.4
[-- Attachment #2: 0003-Fix-double-LIST_REMOVE-device.patch --]
[-- Type: application/octet-stream, Size: 1009 bytes --]
From 20589201a28f80d8d240312d4bb59af68d299eea Mon Sep 17 00:00:00 2001
From: Weidong Han <weidong.han@intel.com>
Date: Wed, 10 Dec 2008 17:23:09 +0800
Subject: [PATCH] Fix double LIST_REMOVE device
adev will be removed in free_assigned_device, shouldn't remove it in assigned_dev_update_irq.
Signed-off-by: Weidong Han <weidong.han@intel.com>
---
qemu/hw/device-assignment.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index c72c57c..20618a4 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -525,7 +525,6 @@ void assigned_dev_update_irq()
adev->name, strerror(-r));
fprintf(stderr, "Perhaps you are assigning a device "
"that shares an IRQ with another device?\n");
- LIST_REMOVE(adev, next);
free_assigned_device(adev);
adev = next;
continue;
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3/4] kvm: qemu: Fix double LIST_REMOVE device
2008-12-10 9:45 [PATCH 3/4] kvm: qemu: Fix double LIST_REMOVE device Han, Weidong
@ 2008-12-10 10:12 ` Mark McLoughlin
0 siblings, 0 replies; 2+ messages in thread
From: Mark McLoughlin @ 2008-12-10 10:12 UTC (permalink / raw)
To: Han, Weidong; +Cc: 'Avi Kivity', kvm@vger.kernel.org
On Wed, 2008-12-10 at 17:45 +0800, Han, Weidong wrote:
> adev will be removed in free_assigned_device, shouldn't remove it in
> assigned_dev_update_irq.
Ouch, yes, good catch.
Cheers,
Mark.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-10 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-10 9:45 [PATCH 3/4] kvm: qemu: Fix double LIST_REMOVE device Han, Weidong
2008-12-10 10:12 ` Mark McLoughlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox