From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Asias He <asias.hejun@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 4/4] kvm tools: Fix virtio console hangs by removing IRQ injection for tx path
Date: Sun, 08 May 2011 20:35:24 +0300 [thread overview]
Message-ID: <1304876124.12850.6.camel@lappy> (raw)
In-Reply-To: <BANLkTikK-kzuZEyWM71kDuWQ1zNtejv0Ew@mail.gmail.com>
On Sun, 2011-05-08 at 20:34 +0300, Pekka Enberg wrote:
> On Sun, May 8, 2011 at 8:29 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> > On Sun, 2011-05-08 at 20:28 +0300, Pekka Enberg wrote:
> >> On Sun, May 8, 2011 at 8:21 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> > I'm seeing no more hangs, but why enable it unconditionally?
> >> > Maybe enable it by default, but we shouldn't force the activation of
> >> > virtio modules if the user doesn't want them.
> >>
> >> I meant enabling the device on PCI bus like we did before.
> >
> > Thats what I've meant too. virtio-console is the only device which got
> > initialized even if it wasn't requested (even when '-c serial' was
> > passed specifically).
>
> The more options we have, the more combinations we need to test.
> What's the downside of enabling virtio console by default? The upside
> is that it's less likely to break. Btw, we should probably do that for
> virtio rng as well.
I fully support enabling it by default, I'm against enabling it even if
the user asked to have it disabled.
--
Sasha.
next prev parent reply other threads:[~2011-05-08 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 13:09 [PATCH v2 0/4] Resend this patch series Asias He
2011-05-08 13:09 ` [PATCH v2 1/4] kvm tools: Use virt_queue__trigger_irq() to trigger IRQ for virtio console Asias He
2011-05-08 13:09 ` [PATCH v2 2/4] kvm tools: Use virt_queue__trigger_irq() to trigger IRQ for virtio blk Asias He
2011-05-08 13:09 ` [PATCH v2 3/4] kvm tools: Use virt_queue__trigger_irq() to trigger IRQ for virtio rng Asias He
2011-05-08 13:09 ` [PATCH v2 4/4] kvm tools: Fix virtio console hangs by removing IRQ injection for tx path Asias He
2011-05-08 17:05 ` Pekka Enberg
2011-05-08 17:21 ` Sasha Levin
2011-05-08 17:28 ` Pekka Enberg
2011-05-08 17:29 ` Sasha Levin
2011-05-08 17:34 ` Pekka Enberg
2011-05-08 17:35 ` Sasha Levin [this message]
2011-05-08 17:41 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304876124.12850.6.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox