public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
	gorcunov@gmail.com
Subject: Re: [PATCH 2/2] kvm tools: Use correct offset for virtio-net config space
Date: Fri, 12 Aug 2011 08:25:57 +0300	[thread overview]
Message-ID: <1313126757.29737.25.camel@jaguar> (raw)
In-Reply-To: <1313095311-7413-2-git-send-email-levinsasha928@gmail.com>

On Thu, 2011-08-11 at 23:41 +0300, Sasha Levin wrote:
> This patch fixes the read action of virtio-net config by not
> handling reads to the start of the space as MSI related
> operations.
> 
> This fixes the MAC configuration of the device and makes uip network
> work again.
> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>

Which commit broke it?

> ---
>  tools/kvm/virtio/net.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c
> index 35d4997..a74f1e7 100644
> --- a/tools/kvm/virtio/net.c
> +++ b/tools/kvm/virtio/net.c
> @@ -221,12 +221,6 @@ static bool virtio_net_pci_io_in(struct ioport *ioport, struct kvm *kvm, u16 por
>  		kvm__irq_line(kvm, pci_header.irq_line, VIRTIO_IRQ_LOW);
>  		ndev.isr = VIRTIO_IRQ_LOW;
>  		break;
> -	case VIRTIO_MSI_CONFIG_VECTOR:
> -		ioport__write16(data, ndev.config_vector);
> -		break;
> -	case VIRTIO_MSI_QUEUE_VECTOR:
> -		ioport__write16(data, ndev.vq_vector[ndev.queue_selector]);
> -		break;
>  	default:
>  		ret = virtio_net_pci_io_device_specific_in(data, offset, size, count);
>  	};



  reply	other threads:[~2011-08-12  5:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 20:41 [PATCH 1/2] kvm tools: Speed up PS/2 mouse detection Sasha Levin
2011-08-11 20:41 ` [PATCH 2/2] kvm tools: Use correct offset for virtio-net config space Sasha Levin
2011-08-12  5:25   ` Pekka Enberg [this message]
2011-08-12  5:50     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313126757.29737.25.camel@jaguar \
    --to=penberg@kernel.org \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox