* [PATCH] vfio: fix crash on rmmod
@ 2013-06-05 6:03 Alexey Kardashevskiy
2013-06-05 15:11 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kardashevskiy @ 2013-06-05 6:03 UTC (permalink / raw)
To: Alex Williamson; +Cc: Alexey Kardashevskiy, kvm, linux-kernel
devtmpfs_delete_node() calls devnode() callback with mode==NULL but
vfio still tries to write there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Steps to reproduce on freshly booted system with no devices given to VFIO:
modprobe vfio
rmmod vfio_iommu_spapr_tce
rmmod vfio
---
drivers/vfio/vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 523c121..259ad28 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -1360,7 +1360,7 @@ static const struct file_operations vfio_device_fops = {
*/
static char *vfio_devnode(struct device *dev, umode_t *mode)
{
- if (MINOR(dev->devt) == 0)
+ if (mode && (MINOR(dev->devt) == 0))
*mode = S_IRUGO | S_IWUGO;
return kasprintf(GFP_KERNEL, "vfio/%s", dev_name(dev));
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] vfio: fix crash on rmmod
2013-06-05 6:03 [PATCH] vfio: fix crash on rmmod Alexey Kardashevskiy
@ 2013-06-05 15:11 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2013-06-05 15:11 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: kvm, linux-kernel
On Wed, 2013-06-05 at 16:03 +1000, Alexey Kardashevskiy wrote:
> devtmpfs_delete_node() calls devnode() callback with mode==NULL but
> vfio still tries to write there.
>
> The patch fixes this.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> ---
Oops. Applied. The mode change just went in for 3.10, so I'll get this
in before the final rc. Thanks,
Alex
> Steps to reproduce on freshly booted system with no devices given to VFIO:
> modprobe vfio
> rmmod vfio_iommu_spapr_tce
> rmmod vfio
> ---
> drivers/vfio/vfio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 523c121..259ad28 100644
> --- a/drivers/vfio/vfio.c
> +++ b/drivers/vfio/vfio.c
> @@ -1360,7 +1360,7 @@ static const struct file_operations vfio_device_fops = {
> */
> static char *vfio_devnode(struct device *dev, umode_t *mode)
> {
> - if (MINOR(dev->devt) == 0)
> + if (mode && (MINOR(dev->devt) == 0))
> *mode = S_IRUGO | S_IWUGO;
>
> return kasprintf(GFP_KERNEL, "vfio/%s", dev_name(dev));
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-05 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05 6:03 [PATCH] vfio: fix crash on rmmod Alexey Kardashevskiy
2013-06-05 15:11 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox