From: Michael Ellerman <michael@ellerman.id.au>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: penberg@kernel.org, will.deacon@arm.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: fix boot of guests with more than 4gb of ram
Date: Tue, 25 Jun 2013 10:58:12 +1000 [thread overview]
Message-ID: <1372121892.11276.2.camel@concordia> (raw)
In-Reply-To: <1372037011-19466-1-git-send-email-sasha.levin@oracle.com>
On Sun, 2013-06-23 at 21:23 -0400, Sasha Levin wrote:
> Commit "kvm tools: virtio: remove hardcoded assumptions
> about guest page size" has introduced a bug that prevented
> guests with more than 4gb of ram from booting.
>
> The issue is that 'pfn' is a 32bit integer, so when multiplying
> it by page size to get the actual page will cause an overflow if
> the pfn referred to a memory area above 4gb.
Couldn't we just make pfn 64 bit?
cheers
next prev parent reply other threads:[~2013-06-25 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 1:23 [PATCH] kvm tools: fix boot of guests with more than 4gb of ram Sasha Levin
2013-06-24 9:05 ` Will Deacon
2013-06-24 10:06 ` Michael Tokarev
2013-07-07 15:29 ` Pekka Enberg
2013-06-25 0:58 ` Michael Ellerman [this message]
2013-06-25 17:02 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372121892.11276.2.camel@concordia \
--to=michael@ellerman.id.au \
--cc=kvm@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox