kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com
Subject: [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries
Date: Fri, 24 Jul 2015 14:07:27 +0200	[thread overview]
Message-ID: <1437739647-30313-1-git-send-email-drjones@redhat.com> (raw)

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 lib/alloc.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/lib/alloc.c b/lib/alloc.c
index 1abe4961ae9dd..fc85d5952c91c 100644
--- a/lib/alloc.c
+++ b/lib/alloc.c
@@ -44,6 +44,7 @@ void phys_alloc_init(phys_addr_t base_addr, phys_addr_t size)
 	base = base_addr;
 	top = base + size;
 	align_min = DEFAULT_MINIMUM_ALIGNMENT;
+	nr_regions = 0;
 	spin_unlock(&lock);
 }
 
@@ -58,6 +59,7 @@ void phys_alloc_set_minimum_alignment(phys_addr_t align)
 static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size,
 					   phys_addr_t align, bool safe)
 {
+	static bool not_warned = true;
 	phys_addr_t addr, size_orig = size;
 	u64 top_safe = top;
 
@@ -72,9 +74,9 @@ static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size,
 	size += addr - base;
 
 	if ((top_safe - base) < size) {
-		printf("%s: requested=0x%llx (align=0x%llx), "
+		printf("phys_alloc: requested=0x%llx (align=0x%llx), "
 		       "need=0x%llx, but free=0x%llx. "
-		       "top=0x%llx, top_safe=0x%llx\n", __func__,
+		       "top=0x%llx, top_safe=0x%llx\n",
 		       size_orig, align, size, top_safe - base,
 		       top, top_safe);
 		spin_unlock(&lock);
@@ -87,9 +89,10 @@ static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size,
 		regions[nr_regions].base = addr;
 		regions[nr_regions].size = size_orig;
 		++nr_regions;
-	} else {
-		printf("%s: WARNING: no free log entries, "
-		       "can't log allocation...\n", __func__);
+	} else if (not_warned) {
+		printf("WARNING: phys_alloc: No free log entries, "
+		       "can no longer log allocations...\n");
+		not_warned = false;
 	}
 
 	spin_unlock(&lock);
-- 
2.4.3


             reply	other threads:[~2015-07-24 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 12:07 Andrew Jones [this message]
2015-07-29 13:52 ` [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries Paolo Bonzini
2015-07-29 14:16   ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437739647-30313-1-git-send-email-drjones@redhat.com \
    --to=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).