Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries
Date: Wed, 29 Jul 2015 16:16:42 +0200	[thread overview]
Message-ID: <20150729141642.GC3722@hawk.localdomain> (raw)
In-Reply-To: <55B8DAB3.9070200@redhat.com>

On Wed, Jul 29, 2015 at 03:52:51PM +0200, Paolo Bonzini wrote:
> 
> 
> On 24/07/2015 14:07, Andrew Jones wrote:
> > @@ -58,6 +59,7 @@ void phys_alloc_set_minimum_alignment(phys_addr_t align)
> >  static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size,
> >  					   phys_addr_t align, bool safe)
> >  {
> > +	static bool not_warned = true;
> 
> I wouldn't object to not having "not" in the name of this variable. :)

yeah, actually I don't like the not in there either, now that you mention
it. v2 coming.

Thanks,
drew

> 
> Otherwise looks okay.
> 
> Paolo
> 
> >  	phys_addr_t addr, size_orig = size;
> >  	u64 top_safe = top;
> >  
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2015-07-29 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 12:07 [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries Andrew Jones
2015-07-29 13:52 ` Paolo Bonzini
2015-07-29 14:16   ` Andrew Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729141642.GC3722@hawk.localdomain \
    --to=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox