From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, mst@redhat.com, agordeev@redhat.com,
rkrcmar@redhat.com
Subject: [kvm-unit-tests PATCH 05/11] x86: mov pci.h to asm
Date: Fri, 15 Jan 2016 17:10:10 +0100 [thread overview]
Message-ID: <1452874216-3087-6-git-send-email-drjones@redhat.com> (raw)
In-Reply-To: <1452874216-3087-1-git-send-email-drjones@redhat.com>
Also move pci_config_read into pci.h from pci.c.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
lib/x86/{ => asm}/pci.h | 8 ++++++++
lib/x86/pci.c | 10 +---------
x86/vmexit.c | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
rename lib/x86/{ => asm}/pci.h (65%)
diff --git a/lib/x86/pci.h b/lib/x86/asm/pci.h
similarity index 65%
rename from lib/x86/pci.h
rename to lib/x86/asm/pci.h
index 046e68f9a65b6..8ad93a87966c6 100644
--- a/lib/x86/pci.h
+++ b/lib/x86/asm/pci.h
@@ -2,6 +2,7 @@
#define PCI_H
#include "libcflat.h"
+#include "asm/io.h"
typedef uint16_t pcidevaddr_t;
enum {
@@ -12,4 +13,11 @@ unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
+static inline uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg)
+{
+ uint32_t index = reg | (dev << 8) | (0x1 << 31);
+ outl(index, 0xCF8);
+ return inl(0xCFC);
+}
+
#endif
diff --git a/lib/x86/pci.c b/lib/x86/pci.c
index 991345ce77858..7002d80836a4c 100644
--- a/lib/x86/pci.c
+++ b/lib/x86/pci.c
@@ -1,13 +1,5 @@
#include <linux/pci_regs.h>
-#include "pci.h"
-#include "asm/io.h"
-
-static uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg)
-{
- uint32_t index = reg | (dev << 8) | (0x1 << 31);
- outl(index, 0xCF8);
- return inl(0xCFC);
-}
+#include "asm/pci.h"
/* Scan bus look for a specific device. Only bus 0 scanned for now. */
pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id)
diff --git a/x86/vmexit.c b/x86/vmexit.c
index 1d74a89567adc..61243a9d63c9a 100644
--- a/x86/vmexit.c
+++ b/x86/vmexit.c
@@ -4,7 +4,7 @@
#include "atomic.h"
#include "x86/vm.h"
#include "x86/desc.h"
-#include "x86/pci.h"
+#include "asm/pci.h"
#include "x86/acpi.h"
#include "asm/io.h"
--
2.4.3
next prev parent reply other threads:[~2016-01-15 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 16:10 [kvm-unit-tests PATCH 00/11] share pci-testdev with the framework Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 01/11] asm-generic: add portio accessors to io.h Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 02/11] x86: move io.h to asm Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 03/11] x86: use common portio accessors from io.h Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 04/11] x86: pci.h: remove useless include Andrew Jones
2016-01-15 16:10 ` Andrew Jones [this message]
2016-01-15 16:10 ` [kvm-unit-tests PATCH 06/11] x86: move x86/pci to the common lib Andrew Jones
2016-01-15 16:27 ` Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 07/11] x86: share pci-testdev hdr in " Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 08/11] lib/pci: make PCIDEVADDR_INVALID truly invalid Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 09/11] lib: add linux dir for kernel uapi headers Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 10/11] Revert "arm/arm64: import include/uapi/linux/psci.h" Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 11/11] lib/linux: import pci_regs.h Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452874216-3087-6-git-send-email-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=agordeev@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox